This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
feat(mdChips): Add md-on-select expression support.
#4088
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topherfangio
added
the
pr: merge ready
|
@typotter ready for review :-) |
|
LGTM |
topherfangio
added
needs: work
and removed
pr: merge ready
topherfangio
force-pushed
the
chips_fix_3413
branch
from
99ebf5c
to
2a19bed
Compare
topherfangio
added
pr: merge ready
topherfangio
force-pushed
the
chips_fix_3413
branch
from
2a19bed
to
369c20f
Compare
| * after selecting a chip from the list. | ||
| * @type {boolean} | ||
| */ | ||
| this.useMdOnSelect = false; |
There was a problem hiding this comment.
This is not a good convention. I recommend:
useMdOnAppend=>useOnAppenduseMdOnRemove=>useOnRemoveuseMdOnSelectExpression=>useOnSelectExpression
topherfangio
added
needs: work
and removed
pr: merge ready
topherfangio
force-pushed
the
chips_fix_3413
branch
from
369c20f
to
d62470c
Compare
topherfangio
added
pr: merge ready
|
@ThomasBurleson Updated based on feedback, should be ready for merge :-) |
Users want a way to be notified when a chip is selected. closes #3413
topherfangio
force-pushed
the
chips_fix_3413
branch
from
d62470c
to
407c1aa
Compare
kennethcachia
pushed a commit
to kennethcachia/material
that referenced
this pull request
Sep 23, 2015
Users want a way to be notified when a chip is selected. fix angular#3413. closes angular#4088.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users want a way to be notified when a chip is selected.
closes #3413