This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(list): fix overflow for ng-click and fix firefox click issues #7503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I recently fixed a issue with the firefox click, and it worked perfectly. But in another commit later I unintentionally *removed* the firefox fix. So this fix reintroduces the fix and made it compatible with the other list fixes. In additon to that, this commit fixes the text overflow for multiline items with ng-click. Fixes angular#7490 Fixes angular#7499
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently fixed a issue with the firefox click, and it worked perfectly. But in another commit later I unintentionally removed the firefox fix. So this fix reintroduces the fix and made it compatible with the other list fixes.
In additon to that, this commit fixes the text overflow for multiline items with ng-click.
@EladBezalel Can you please review that asap?
Fixes #7490 Fixes #7499