This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(sidenav): don't log an error when waiting for an instance. #8326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var instance = $mdComponentRegistry.get(handle); | ||
| if(!instance) { | ||
|
|
||
| if(!instance && !shouldWait) { |
There was a problem hiding this comment.
Nitpicky as always :) - Please add space for consistency.
There was a problem hiding this comment.
It wasn't my changes this time! Thanks for the tip, though :)
* The `$mdSidenav` service was logging errors, even if the option to wait for an asynchronous instance was passed. This changes it to only log if the lookup for the instance is synchronous. * Fixes the error for an invalid sidenav instance name not being logged if the `enableWait` argument is passed. * Adds info about the async argument of `$mdSidenav` in the docs. Fixes angular#8308.
crisbeto
force-pushed
the
fix/async-sidenav
branch
from
c6bb6a7
to
02fbbc7
Compare
ThomasBurleson
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$mdSidenavservice was logging errors, even if the option to wait for an asynchronous instance was passed. This changes it to only log if the lookup for the instance is synchronous.enableWaitargument is passed.$mdSidenavin the docs.Fixes #8308.