Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devel to main release March 23 #256

Merged
merged 151 commits into from
Mar 2, 2023
Merged

Devel to main release March 23 #256

merged 151 commits into from
Mar 2, 2023

Conversation

uk-bolly
Copy link
Member

@uk-bolly uk-bolly commented Mar 1, 2023 •
edited
Loading

Overall Review of Changes:
Various issue fixes and PR implementations

Issue Fixes:

Enhancements:
General

  • Linting updates
  • Added warning reports to end of playbook run
  • Added assert for Ansible User
  • Minor CI/CD updates (these are internal functional tests)
  • warning method update
  • various vars not used removed
  • Initial Oracle files added - requires feedback
  • change of varlog_location variable name to sudolog_location
  • update to blacklist checks for related modprobe files
  • update to spacing in sudo_log
  • update to 32b check for kernel_module keys 4.1.3.19
  • workflow updates versions of actions and improvements

PR's

How has this been tested?:
Locally and CI/CD
Issue Fixes:
Please list (using linking) any open issues this PR addresses

Enhancements:
Please list any enhancements/features that are not open issue tickets

How has this been tested?:
Please give an overview of how these changes were tested. If they were not please use N/A

uk-bolly and others added 30 commits July 6, 2022 14:49
@uk-bolly
Added gdm pkg as requirement for dconf install
7f162fc 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
added dconf pkg check back
0215e3e 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated reboot var description and moved to vars/main.yml
5149136 
Signed-off-by: Mark Bolwell <[email protected]>
@georgenalen
updated defaults/main to not have change_requires_reboot variable
d27e413 
Signed-off-by: George Nalen <[email protected]>
@uk-bolly
removed the needs reboot to var/main.yml as default
d6d0ff0 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
Merge branch 'issue_215' of github.com:ansible-lockdown/RHEL8-CIS int…
8bb9d9e 
…o issue_215

Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
update to repo lifecycle and support
545366f 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated lifecycle and links
8e0c5d6 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
improvements to 4.2.3 and default settings
de081f3 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
added warning summary to end of play
127ad38 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
Updated test and added warning count
ff8d152 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
Added warning count fact
3e2a066 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
Updated warning added count
afa32da 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated output warn count output
056e6e0 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated control_number default
bb91664 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
standard the control_id var
5dbff68 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated less blocks
b9fc1ef 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated warning count
5e57c24 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
Merge pull request #217 from ansible-lockdown/issue_216
e3b87ce 
Issue 216 - dconf installed although not needed
@uk-bolly
Merge pull request #218 from ansible-lockdown/issue_215
ef10a88 
Issue 215
@uk-bolly
Merge pull request #219 from ansible-lockdown/4.2.3_and_warnings
22cd0fa 
4.2.3 and warnings
@cf-sewe
Removed unneeded whitespace
cc0cd40 
Signed-off-by: Sebastian W <[email protected]>
@uk-bolly
Merge pull request #221 from cf-sewe/fix/5_6_2-typo
33d4c64 
Fix for 5.6.2 - Remove unneeded whitespace in when clause
@uk-bolly
changed conditional for better warn msg
c8090fe 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated release data
70edd54 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
fixed typo
8b1e416 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated link for bugid
b160e7e 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
Merge pull request #223 from ansible-lockdown/warning_summary
26060e6 
Warning summary improvement
@uk-bolly
updated workflows
62e0401 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
lint
103ec88 
Signed-off-by: Mark Bolwell <[email protected]>
uk-bolly and others added 24 commits February 1, 2023 10:57
@uk-bolly
updated warning method
552c63c 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
#248 initial added - needs testing
75f9907 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
6.1.5 conditional
cf1caef 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
removed adhoc layout change
8ee2514 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
#249
e2e882f 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated
2c8dbaf 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated
d162e52 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated to skip nameplay
47db997 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
lint updates
df31dc8 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
added file
8a3a177 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
removed script not required
8792270 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
removed repetition of vars
76de17f 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
moved prereqs to prelims tasks
75e3712 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
moved prereqs to prelims tasks
a841eec 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated
0033ed5 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
linting
4ed9c15 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated pre-reqs statements
cb12cb5 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
fixed merge errors
8760f8e 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
Merge pull request #251 from ansible-lockdown/jan_23_updates
3378569 
Jan 23 updates
@Thulium-Drake
Fix #253
014af6a 
Signed-off-by: Jeffrey van Pelt <[email protected]>
@uk-bolly
Merge pull request #254 from Thulium-Drake/fix_253
89b2a7a 
Fix #253
@uk-bolly
added new option to 6.2.9 to not follow symlinks
2121b30 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
added change details
136faf6 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
Merge pull request #255 from ansible-lockdown/PR_252-6_2_9
34bb386 
Pr 252 6 2 9
@uk-bolly
Copy link
Member Author

uk-bolly commented Mar 1, 2023 •
edited
Loading

DCO is expected due to historical issues with gpg key
pipeline failure also expected as workflow update in this merge - latest run into devel (same pipeline worked) https:/ansible-lockdown/RHEL8-CIS/actions/runs/4172077028

@uk-bolly uk-bolly mentioned this pull request Mar 1, 2023
Closed
@uk-bolly uk-bolly marked this pull request as ready for review March 1, 2023 13:36
georgenalen
georgenalen approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@georgenalen georgenalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@uk-bolly uk-bolly merged commit c993d0c into main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgenalen georgenalen georgenalen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@uk-bolly @georgenalen @cf-sewe @Thulium-Drake