Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devel to main release March 23 #256

Merged
merged 151 commits into from
Mar 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
151 commits
Select commit Hold shift + click to select a range
7f162fc
Added gdm pkg as requirement for dconf install
uk-bolly Jul 6, 2022
0215e3e
added dconf pkg check back
uk-bolly Jul 6, 2022
5149136
updated reboot var description and moved to vars/main.yml
uk-bolly Jul 6, 2022
d27e413
updated defaults/main to not have change_requires_reboot variable
georgenalen Jul 6, 2022
d6d0ff0
removed the needs reboot to var/main.yml as default
uk-bolly Jul 6, 2022
8bb9d9e
Merge branch 'issue_215' of github.com:ansible-lockdown/RHEL8-CIS int…
uk-bolly Jul 6, 2022
545366f
update to repo lifecycle and support
uk-bolly Jul 7, 2022
8e0c5d6
updated lifecycle and links
uk-bolly Jul 7, 2022
de081f3
improvements to 4.2.3 and default settings
uk-bolly Jul 8, 2022
127ad38
added warning summary to end of play
uk-bolly Jul 8, 2022
ff8d152
Updated test and added warning count
uk-bolly Jul 8, 2022
3e2a066
Added warning count fact
uk-bolly Jul 8, 2022
afa32da
Updated warning added count
uk-bolly Jul 8, 2022
056e6e0
updated output warn count output
uk-bolly Jul 8, 2022
bb91664
updated control_number default
uk-bolly Jul 8, 2022
5dbff68
standard the control_id var
uk-bolly Jul 8, 2022
b9fc1ef
updated less blocks
uk-bolly Jul 8, 2022
5e57c24
updated warning count
uk-bolly Jul 8, 2022
e3b87ce
Merge pull request #217 from ansible-lockdown/issue_216
uk-bolly Jul 13, 2022
ef10a88
Merge pull request #218 from ansible-lockdown/issue_215
uk-bolly Jul 13, 2022
22cd0fa
Merge pull request #219 from ansible-lockdown/4.2.3_and_warnings
uk-bolly Jul 13, 2022
cc0cd40
Removed unneeded whitespace
cf-sewe Jul 15, 2022
33d4c64
Merge pull request #221 from cf-sewe/fix/5_6_2-typo
uk-bolly Jul 15, 2022
c8090fe
changed conditional for better warn msg
uk-bolly Jul 28, 2022
70edd54
updated release data
uk-bolly Jul 28, 2022
8b1e416
fixed typo
uk-bolly Jul 28, 2022
b160e7e
updated link for bugid
uk-bolly Jul 28, 2022
26060e6
Merge pull request #223 from ansible-lockdown/warning_summary
uk-bolly Jul 28, 2022
62e0401
updated workflows
uk-bolly Aug 5, 2022
103ec88
lint
uk-bolly Aug 5, 2022
dbe18dd
aded sleep as amazon slower at times
uk-bolly Aug 5, 2022
10214af
updated to latest settings
uk-bolly Aug 23, 2022
0c48c6f
Changed to 60sec pause for OS
uk-bolly Aug 23, 2022
f5a847e
Merge branch 'devel' into workflow
uk-bolly Aug 23, 2022
9e8e4ef
Added Assertion for passwd set on ansible user
uk-bolly Sep 7, 2022
14dd014
added blank line - lint
uk-bolly Sep 14, 2022
0eb6e86
add tftp client for audit
uk-bolly Sep 15, 2022
ef5b32d
updated
uk-bolly Sep 15, 2022
b5ee817
updated date
uk-bolly Sep 15, 2022
dcdfc05
lint updates
uk-bolly Sep 15, 2022
23438de
lint updates
uk-bolly Sep 15, 2022
93e6507
tidy up and lint
uk-bolly Sep 15, 2022
dede597
lint and boolean
uk-bolly Sep 15, 2022
a176eae
boolean and lint
uk-bolly Sep 15, 2022
27fc6ed
boolean
uk-bolly Sep 15, 2022
7662cc1
lint
uk-bolly Sep 15, 2022
135e9b9
boolean and lint
uk-bolly Sep 15, 2022
311ade7
boolean and lint updates
uk-bolly Sep 15, 2022
40d848f
booleans and lint updates
uk-bolly Sep 15, 2022
1bd1ad3
boolean and lint
uk-bolly Sep 15, 2022
af622e1
boolean and lint updates
uk-bolly Sep 15, 2022
2baf08a
linting
uk-bolly Sep 15, 2022
b58e659
changelog updates
uk-bolly Sep 15, 2022
95ec1fb
lint improvements
uk-bolly Sep 16, 2022
9272eac
lint exclusions added
uk-bolly Sep 16, 2022
0ba002f
updated logic
uk-bolly Sep 16, 2022
39801da
removed unnecessary checks
uk-bolly Sep 16, 2022
22329b3
Merge pull request #224 from ansible-lockdown/workflow
uk-bolly Sep 16, 2022
abd834e
added missing control for audit
uk-bolly Sep 27, 2022
42ff05c
Merge pull request #229 from ansible-lockdown/audit-sync
uk-bolly Oct 6, 2022
1f756c6
#228 goss copy source added
uk-bolly Oct 10, 2022
0c472ad
updated goss version
uk-bolly Oct 10, 2022
f4b56a3
updated server/client variables
uk-bolly Oct 10, 2022
e73cdcf
variable updated - audit out path
uk-bolly Oct 10, 2022
f557ddb
#226 auditd extension
uk-bolly Oct 11, 2022
ed2c8cd
updated
uk-bolly Oct 11, 2022
ac41535
linting
uk-bolly Oct 11, 2022
bcd6bb8
moved include tasks to import for tagging
uk-bolly Oct 12, 2022
99e295a
#209 login.defs
uk-bolly Oct 14, 2022
8b88e17
lint fix
uk-bolly Oct 14, 2022
f2f2ec7
updated link to discord and welcome release
uk-bolly Oct 14, 2022
4e2867f
lint updates
uk-bolly Oct 25, 2022
e93f305
moved from include to import tasks
uk-bolly Oct 25, 2022
a175619
updated
uk-bolly Oct 25, 2022
620265d
moved extra optional taks to prelim
uk-bolly Oct 27, 2022
5ab7670
Merge pull request #230 from ansible-lockdown/Oct_update
uk-bolly Nov 1, 2022
c54053a
fix for #232
georgenalen Nov 21, 2022
764bd1e
fix for issue #235 and #236
georgenalen Nov 21, 2022
7256cdd
updated comments around 2.2.18 and 2.2.19
georgenalen Nov 21, 2022
980052b
Added PR #233 changes to control 6.2.10
georgenalen Nov 21, 2022
413e8ac
linting fixes
georgenalen Nov 21, 2022
9ba29bb
updated changelog for latest pr
georgenalen Nov 22, 2022
f5c4135
Merge pull request #240 from ansible-lockdown/november_2022_updates
georgenalen Nov 22, 2022
b22b08d
#228 goss copy source added
uk-bolly Oct 10, 2022
4f8d342
updated goss version
uk-bolly Oct 10, 2022
ce4e4b3
updated server/client variables
uk-bolly Oct 10, 2022
c506234
variable updated - audit out path
uk-bolly Oct 10, 2022
88af5a5
#226 auditd extension
uk-bolly Oct 11, 2022
d8b434d
updated
uk-bolly Oct 11, 2022
bc63e2b
linting
uk-bolly Oct 11, 2022
73ac840
moved include tasks to import for tagging
uk-bolly Oct 12, 2022
75a0912
#209 login.defs
uk-bolly Oct 14, 2022
397dc80
lint fix
uk-bolly Oct 14, 2022
5228fc4
updated link to discord and welcome release
uk-bolly Oct 14, 2022
430e603
lint updates
uk-bolly Oct 25, 2022
20b3323
moved from include to import tasks
uk-bolly Oct 25, 2022
f50befd
updated
uk-bolly Oct 25, 2022
d4526b0
moved extra optional taks to prelim
uk-bolly Oct 27, 2022
4cc7cb9
fix for #232
georgenalen Nov 21, 2022
cf0bac7
fix for issue #235 and #236
georgenalen Nov 21, 2022
45cbd68
updated comments around 2.2.18 and 2.2.19
georgenalen Nov 21, 2022
41b26b6
Added PR #233 changes to control 6.2.10
georgenalen Nov 21, 2022
47ce4d8
linting fixes
georgenalen Nov 21, 2022
cb4274a
updated changelog for latest pr
georgenalen Nov 22, 2022
b5188b8
added blacklist requirement
uk-bolly Jan 16, 2023
a20f0ab
spacing updated
uk-bolly Jan 16, 2023
01e1c1f
updated rp_filter
uk-bolly Jan 16, 2023
1b56183
updated blacklist
uk-bolly Jan 16, 2023
e8ac513
updated blacklist
uk-bolly Jan 16, 2023
48fd241
changed spacing
uk-bolly Jan 16, 2023
d98f172
updated b32 rule
uk-bolly Jan 16, 2023
3bc9f60
updated varlog_location variable
uk-bolly Jan 16, 2023
a7c9590
fix typo
uk-bolly Jan 16, 2023
e60fef3
update sudo log location
uk-bolly Jan 16, 2023
0860d78
updated
uk-bolly Jan 16, 2023
4b0d100
updated actions versions
uk-bolly Jan 17, 2023
0a8bcfc
added missing tags thanks to @blooch in discord community
uk-bolly Jan 17, 2023
02f3526
#242 fixed typos thanks to @strangelittlemonkey
uk-bolly Jan 17, 2023
f0e8b35
#244 incorporated
uk-bolly Jan 17, 2023
807b6f0
#250
uk-bolly Jan 17, 2023
4a27601
#243 thanks to @fnschroeder
uk-bolly Jan 17, 2023
12339a2
updated goss version, checksum,url
uk-bolly Jan 18, 2023
0ec6aab
removed travis entries not required
uk-bolly Jan 24, 2023
d9efad6
removed not_auto var
uk-bolly Jan 24, 2023
a9d1405
#245 logic applied
uk-bolly Jan 24, 2023
7fdf6a8
removed library file added callbacks
uk-bolly Jan 24, 2023
16c074a
removed travis
uk-bolly Jan 24, 2023
552c63c
updated warning method
uk-bolly Jan 24, 2023
75f9907
#248 initial added - needs testing
uk-bolly Jan 27, 2023
cf1caef
6.1.5 conditional
uk-bolly Jan 27, 2023
8ee2514
removed adhoc layout change
uk-bolly Jan 27, 2023
e2e882f
#249
uk-bolly Jan 27, 2023
2c8dbaf
updated
uk-bolly Jan 27, 2023
d162e52
updated
uk-bolly Jan 27, 2023
47db997
updated to skip nameplay
uk-bolly Jan 27, 2023
df31dc8
lint updates
uk-bolly Jan 27, 2023
8a3a177
added file
uk-bolly Jan 30, 2023
8792270
removed script not required
uk-bolly Jan 30, 2023
76de17f
removed repetition of vars
uk-bolly Jan 31, 2023
75e3712
moved prereqs to prelims tasks
uk-bolly Jan 31, 2023
a841eec
moved prereqs to prelims tasks
uk-bolly Jan 31, 2023
0033ed5
updated
uk-bolly Jan 31, 2023
4ed9c15
linting
uk-bolly Jan 31, 2023
cb12cb5
updated pre-reqs statements
uk-bolly Feb 1, 2023
8760f8e
fixed merge errors
uk-bolly Feb 1, 2023
3378569
Merge pull request #251 from ansible-lockdown/jan_23_updates
uk-bolly Feb 1, 2023
014af6a
Fix #253
Thulium-Drake Feb 8, 2023
89b2a7a
Merge pull request #254 from Thulium-Drake/fix_253
uk-bolly Feb 8, 2023
2121b30
added new option to 6.2.9 to not follow symlinks
uk-bolly Feb 14, 2023
136faf6
added change details
uk-bolly Feb 14, 2023
34bb386
Merge pull request #255 from ansible-lockdown/PR_252-6_2_9
uk-bolly Feb 15, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions .ansible-lint
Original file line number Diff line number Diff line change
@@ -1,11 +1,21 @@
parseable: true
quiet: true
skip_list:
- '204'
- '305'
- '303'
- '403'
- '306'
- '602'
- 'schema'
- 'no-changed-when'
- 'var-spacing'
- 'fqcn-builtins'
- 'experimental'
- 'name[play]'
- 'name[casing]'
- 'name[template]'
- 'fqcn[action]'
- '204'
- '305'
- '303'
- '403'
- '306'
- '602'
- '208'
use_default_rules: true
verbosity: 0
44 changes: 43 additions & 1 deletion .github/workflows/github_networks.tf
Original file line number Diff line number Diff line change
@@ -1,11 +1,53 @@
resource "aws_vpc" "Main" {
cidr_block = var.main_vpc_cidr
tags = var.instance_tags
instance_tenancy = "default"
tags = {
Environment = "${var.environment}"
Name = "${var.namespace}-VPC"
}
}

resource "aws_internet_gateway" "IGW" {
vpc_id = aws_vpc.Main.id
tags = {
Environment = "${var.environment}"
Name = "${var.namespace}-IGW"
}
}

resource "aws_subnet" "publicsubnets" {
vpc_id = aws_vpc.Main.id
cidr_block = var.public_subnets
availability_zone = var.availability_zone
tags = {
Environment = "${var.environment}"
Name = "${var.namespace}-pubsub"
}
}

resource "aws_subnet" "Main" {
vpc_id = aws_vpc.Main.id
availability_zone = var.availability_zone
cidr_block = var.private_subnets
tags = {
Environment = "${var.environment}"
Name = "${var.namespace}-prvsub"
}
}

resource "aws_route_table" "PublicRT" {
vpc_id = aws_vpc.Main.id
route {
cidr_block = "0.0.0.0/0"
gateway_id = aws_internet_gateway.IGW.id
}
tags = {
Environment = "${var.environment}"
Name = "${var.namespace}-publicRT"
}
}

resource "aws_route_table_association" "rt_associate_public" {
subnet_id = aws_subnet.Main.id
route_table_id = aws_route_table.PublicRT.id
}
3 changes: 2 additions & 1 deletion .github/workflows/github_vars.tfvars
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,10 @@
//

namespace = "github_actions"
environment = "lockdown_github_repo_workflow"

// Matching pair name found in AWS for keypairs PEM key
ami_key_pair_name = "github_actions"
main_vpc_cidr = "172.22.0.0/24"
public_subnets = "172.22.0.128/26"
private_subnets = "172.22.0.192/26"
private_subnets = "172.22.0.192/26"
21 changes: 6 additions & 15 deletions .github/workflows/linux_benchmark_testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/first-interaction@v1.1.0
- uses: actions/first-interaction@main
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
pr-message: |-
Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the [Discord Server](https://discord.gg/JFxpSgPFEJ) as well.
Please join in the conversation happening on the [Discord Server](https://discord.io/ansible-lockdown) as well.
# This workflow contains a single job called "build"
build:
# The type of runner that the job will run on
Expand All @@ -44,7 +44,7 @@ jobs:
steps:
# Checks-out your repository under $GITHUB_WORKSPACE,
# so your job can access it
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
ref: ${{ github.event.pull_request.head.sha }}

Expand Down Expand Up @@ -81,18 +81,9 @@ jobs:
working-directory: .github/workflows
run: cat hosts.yml

# Centos 7 images take a while to come up insert sleep or playbook fails
# Aws deployments taking a while to come up insert sleep or playbook fails

- name: Check if test os is rhel7
working-directory: .github/workflows
id: test_os
run: >-
echo "::set-output name=RHEL7::$(
grep -c RHEL7 OS.tfvars
)"

- name: if RHEL7 - Sleep for 60 seconds
if: steps.test_os.outputs.RHEL7 >= 1
- name: Sleep for 60 seconds
run: sleep 60s
shell: bash

Expand All @@ -117,4 +108,4 @@ jobs:
env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
run: terraform destroy -var-file "OS.tfvars" -var-file "github_vars.tfvars" --auto-approve -input=false
run: terraform destroy -var-file "github_vars.tfvars" -var-file "OS.tfvars" --auto-approve -input=false
20 changes: 10 additions & 10 deletions .github/workflows/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ provider "aws" {

// Create a security group with access to port 22 and port 80 open to serve HTTP traffic

data "aws_vpc" "default" {
default = true
}

resource "random_id" "server" {
keepers = {
Expand All @@ -19,16 +16,16 @@ resource "random_id" "server" {
}

resource "aws_security_group" "github_actions" {
name = "${var.namespace}-${random_id.server.hex}"
vpc_id = data.aws_vpc.default.id
name = "${var.namespace}-${random_id.server.hex}-SG"
vpc_id = aws_vpc.Main.id

ingress {
from_port = 22
to_port = 22
protocol = "tcp"
cidr_blocks = ["0.0.0.0/0"]
}

ingress {
from_port = 80
to_port = 80
Expand All @@ -43,30 +40,33 @@ resource "aws_security_group" "github_actions" {
cidr_blocks = ["0.0.0.0/0"]
}
tags = {
Environment = "${var.environment}"
Name = "${var.namespace}-SG"
}
}
}

// instance setup

resource "aws_instance" "testing_vm" {
ami = var.ami_id
availability_zone = var.availability_zone
associate_public_ip_address = true
key_name = var.ami_key_pair_name # This is the key as known in the ec2 key_pairs
instance_type = var.instance_type
tags = var.instance_tags
vpc_security_group_ids = [aws_security_group.github_actions.id]
subnet_id = aws_subnet.Main.id
root_block_device {
delete_on_termination = true
delete_on_termination = true
}
}

// generate inventory file
resource "local_file" "inventory" {
filename = "./hosts.yml"
filename = "./hosts.yml"
directory_permission = "0755"
file_permission = "0644"
content = <<EOF
content = <<EOF
# benchmark host
all:
hosts:
Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/test.sh

This file was deleted.

20 changes: 20 additions & 0 deletions .github/workflows/update_galaxy.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
---

# This is a basic workflow to help you get started with Actions

name: update galaxy

# Controls when the action will run.
# Triggers the workflow on merge request events to the main branch
on:
push:
branches:
- main
jobs:
update_role:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: hspaans/ansible-galaxy-action@master
with:
api_key: ${{ secrets.GALAXY_API_KEY }}
15 changes: 13 additions & 2 deletions .github/workflows/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ variable "aws_region" {
type = string
}

variable "availability_zone" {
description = "List of availability zone in the region"
default = "us-east-1b"
type = string
}

variable "instance_type" {
description = "EC2 Instance Type"
default = "t3.micro"
Expand All @@ -29,7 +35,7 @@ variable "ami_os" {

variable "ami_id" {
description = "AMI ID reference"
type = string
type = string
}

variable "ami_username" {
Expand All @@ -47,6 +53,11 @@ variable "namespace" {
type = string
}

variable "environment" {
description = "Env Name used across all tags"
type = string
}

// taken from github_vars.tfvars &

variable "main_vpc_cidr" {
Expand All @@ -62,4 +73,4 @@ variable "public_subnets" {
variable "private_subnets" {
description = "private subnet cidr block"
type = string
}
}
35 changes: 22 additions & 13 deletions .yamllint
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,31 @@
ignore: |
tests/
molecule/
.github/
.gitlab-ci.yml
*molecule.yml

extends: default

rules:
indentation:
# Requiring 4 space indentation
spaces: 4
# Requiring consistent indentation within a file, either indented or not
indent-sequences: consistent
truthy: disable
braces:
max-spaces-inside: 1
level: error
brackets:
max-spaces-inside: 1
level: error
line-length: disable
indentation:
# Requiring 4 space indentation
spaces: 4
# Requiring consistent indentation within a file, either indented or not
indent-sequences: consistent
#truthy: disable
braces:
max-spaces-inside: 1
level: error
brackets:
max-spaces-inside: 1
level: error
line-length: disable
key-duplicates: enable
new-line-at-end-of-file: enable
new-lines:
type: unix
trailing-spaces: enable
truthy:
allowed-values: ['true', 'false']
check-keys: true
Loading