Use parameterized logging instead of string concatenation #1982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppkarwasz
force-pushed
the
rewrite-parameterized
branch
from
734e548
to
0916b55
Compare
Our code should be an example to users: we should never use string concatenation in log messages. This was performed using OpenRewrite and is related to apache#1706.
ppkarwasz
force-pushed
the
rewrite-parameterized
branch
from
0916b55
to
8d238bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our code should be an example to users. Therefore we can not use string concatenation in logging statements, but we should use parameterized logging.
This PR uses the Parameterize Log4j 2.x logging statements and is part of #1706.