Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.0.0-alpha2 PushConsumer Shutdown #130

Closed
banbo opened this issue Jul 25, 2019 · 4 comments
Closed

2.0.0-alpha2 PushConsumer Shutdown #130

banbo opened this issue Jul 25, 2019 · 4 comments
Labels
enhancement New feature or request
Milestone
Native-2.0.0-alpha3

Comments

@banbo
Copy link

banbo commented Jul 25, 2019 •
edited
Loading

2.0.0-alpha2 PushConsumer Shutdown function is just return nil，when can this approach be implemented?

func (pc *pushConsumer) Shutdown() error {
	return nil
}
@wenfengwang
Copy link
Member

it will be fixed in next release: 2.0.0-rc1. it will be released at 8.7

@banbo
Copy link
Author

banbo commented Aug 9, 2019

it will be fixed in next release: 2.0.0-rc1. it will be released at 8.7

8.7 release still not implement this func, i am wait for this func, the cgo version is not work good

@wenfengwang
Copy link
Member

the 2.0.0-rc1 has been postponed, we are doing our best for releasing it on 8.14 around.

@wenfengwang wenfengwang mentioned this issue Aug 13, 2019
Closed
26 tasks
@wenfengwang
Copy link
Member

fixed at: #172

@ShannonDing ShannonDing added this to the Native-2.0.0-alpha3 milestone Aug 23, 2019
@ShannonDing ShannonDing added the enhancement New feature or request label Aug 23, 2019
zongtanghu pushed a commit that referenced this issue Aug 26, 2019
@wenfengwang @zongtanghu
[ISSUE #130] Add Shutdown of PushConsumer (#172)
2a210ad 
* fix issue 130

* fix CR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Native-2.0.0-alpha3
Development

No branches or pull requests
3 participants
@wenfengwang @banbo @ShannonDing