Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #130] Add Shutdown of PushConsumer #172

Merged
merged 2 commits into from
Aug 26, 2019

Conversation

wenfengwang
Copy link
Member

What is the purpose of the change

Add Shutdown of PushConsumer

Brief changelog

  • Add Shutdown of PushConsumer
  • Add mqChanged impl of PushConsumer

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-io
Copy link

codecov-io commented Aug 23, 2019

Codecov Report

Merging #172 into native will decrease coverage by 0.18%.
The diff coverage is 2.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           native     #172      +/-   ##
==========================================
- Coverage   24.34%   24.16%   -0.19%     
==========================================
  Files          44       44              
  Lines        4608     4643      +35     
==========================================
  Hits         1122     1122              
- Misses       3338     3373      +35     
  Partials      148      148
Impacted Files Coverage Δ
consumer/consumer.go 3.79% <0%> (-0.07%) ⬇️
consumer/push_consumer.go 14.91% <3.7%> (-0.76%) ⬇️
internal/utils/net.go 47.36% <0%> (ø) ⬆️
internal/mock_namesrv.go 0% <0%> (ø) ⬆️
internal/mock_client.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e572801...63b9896. Read the comment docs.

@wenfengwang wenfengwang mentioned this pull request Aug 23, 2019
26 tasks
@ShannonDing ShannonDing added the enhancement New feature or request label Aug 23, 2019
@ShannonDing ShannonDing added this to the Native-2.0.0-alpha3 milestone Aug 23, 2019
api.go Show resolved Hide resolved
consumer/push_consumer.go Outdated Show resolved Hide resolved
@xujianhai666
Copy link
Member

LGTM

@zongtanghu zongtanghu merged commit 2a210ad into apache:native Aug 26, 2019
@wenfengwang wenfengwang deleted the issue-130 branch November 28, 2019 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants