Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow passing extra options like proxyUrl on type level #88

Merged
merged 1 commit into from
Mar 14, 2023
Merged

fix: allow passing extra options like proxyUrl on type level #88

merged 1 commit into from
Mar 14, 2023

Conversation

vladfrangu
Copy link
Member

@vladfrangu vladfrangu commented Mar 13, 2023 •
edited by B4nan
Loading

This solves an internally reported issue where using got-scraping would not include our custom options (like proxyUrl)

Closes #66

@vladfrangu vladfrangu requested a review from B4nan March 13, 2023 11:05
B4nan
B4nan approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good I guess, let's test this via crawlee test suite (jest + e2e) to be sure (once merged, but before stable release).

@B4nan
Copy link
Member

B4nan commented Mar 13, 2023

Also, there are tests that should no longer need the type assertions to OptionsInit.

@B4nan B4nan changed the title types: extend got interface with our types fix: allow passing extra options like proxyUrl on type level Mar 13, 2023
@vladfrangu
Copy link
Member Author

Looking good I guess, let's test this via crawlee test suite (jest + e2e) to be sure (once merged, but before stable release).

Hard to do without this merged / released 😓, or? should I try it out with patch-package?

@B4nan
Copy link
Member

B4nan commented Mar 13, 2023

After this gets merged of course, on the got scraping beta.

@B4nan B4nan merged commit aa1d997 into master Mar 14, 2023
@vladfrangu vladfrangu mentioned this pull request Mar 17, 2023
Closed
@vladfrangu vladfrangu deleted the fix/extended-types-missing branch November 16, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B4nan B4nan B4nan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript options error
2 participants
@vladfrangu @B4nan