Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow passing extra options like proxyUrl on type level #88

Merged
merged 1 commit into from
Mar 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/index.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import http from 'http';
import https from 'https';

import { got as gotCjs, Options } from 'got-cjs';
import { Got, got as gotCjs, HTTPAlias, Options } from 'got-cjs';
import { HeaderGenerator } from 'header-generator';

import { TransformHeadersAgent } from './agent/transform-headers-agent';
Expand All @@ -16,6 +16,7 @@ import { tlsHook } from './hooks/tls';
import { sessionDataHook } from './hooks/storage';
import { fixDecompress } from './hooks/fix-decompress';
import { refererHook } from './hooks/referer';
import { ExtendedGotRequestFunction } from './types';

const gotScraping = gotCjs.extend({
handlers: [
Expand Down Expand Up @@ -62,7 +63,7 @@ const gotScraping = gotCjs.extend({
refererHook,
],
},
});
}) as Got & Record<HTTPAlias, ExtendedGotRequestFunction> & ExtendedGotRequestFunction;

/**
* Mock the `decodeURI` global for the time when Got is normalizing the URL.
Expand Down
58 changes: 58 additions & 0 deletions src/types.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
import { CancelableRequest, Options, Request, Response } from 'got-cjs';
import { OptionsInit } from './context';

type Except<ObjectType, KeysType extends keyof ObjectType> = Pick<ObjectType, Exclude<keyof ObjectType, KeysType>>;
type Merge<FirstType, SecondType> = Except<FirstType, Extract<keyof FirstType, keyof SecondType>> & SecondType;

export interface ExtendedGotRequestFunction {
(url: string | URL, options?: ExtendedOptionsOfTextResponseBody): CancelableRequest<Response<string>>;
<T>(url: string | URL, options?: ExtendedOptionsOfJSONResponseBody): CancelableRequest<Response<T>>;
(url: string | URL, options?: ExtendedOptionsOfBufferResponseBody): CancelableRequest<Response<Buffer>>;
(url: string | URL, options?: ExtendedOptionsOfUnknownResponseBody): CancelableRequest<Response>;
(options: ExtendedOptionsOfTextResponseBody): CancelableRequest<Response<string>>;
<T>(options: ExtendedOptionsOfJSONResponseBody): CancelableRequest<Response<T>>;
(options: ExtendedOptionsOfBufferResponseBody): CancelableRequest<Response<Buffer>>;
(options: ExtendedOptionsOfUnknownResponseBody): CancelableRequest<Response>;
(url: string | URL, options?: (Merge<ExtendedOptionsOfTextResponseBody, ResponseBodyOnly>)): CancelableRequest<string>;
<T>(url: string | URL, options?: (Merge<ExtendedOptionsOfJSONResponseBody, ResponseBodyOnly>)): CancelableRequest<T>;
(url: string | URL, options?: (Merge<ExtendedOptionsOfBufferResponseBody, ResponseBodyOnly>)): CancelableRequest<Buffer>;
(options: (Merge<ExtendedOptionsOfTextResponseBody, ResponseBodyOnly>)): CancelableRequest<string>;
<T>(options: (Merge<ExtendedOptionsOfJSONResponseBody, ResponseBodyOnly>)): CancelableRequest<T>;
(options: (Merge<ExtendedOptionsOfBufferResponseBody, ResponseBodyOnly>)): CancelableRequest<Buffer>;
(url: string | URL, options?: Merge<OptionsInit, {
isStream: true;
}>): Request;
(options: Merge<OptionsInit, {
isStream: true;
}>): Request;
(url: string | URL, options?: OptionsInit): CancelableRequest | Request;
(options: OptionsInit): CancelableRequest | Request;
(url: undefined, options: undefined, defaults: Options): CancelableRequest | Request;
}

export type ExtendedOptionsOfTextResponseBody = Merge<OptionsInit, {
isStream?: false;
resolveBodyOnly?: false;
responseType?: 'text';
}>

export type ExtendedOptionsOfJSONResponseBody = Merge<OptionsInit, {
isStream?: false;
resolveBodyOnly?: false;
responseType?: 'json';
}>;

export type ExtendedOptionsOfBufferResponseBody = Merge<OptionsInit, {
isStream?: false;
resolveBodyOnly?: false;
responseType: 'buffer';
}>;

export type ExtendedOptionsOfUnknownResponseBody = Merge<OptionsInit, {
isStream?: false;
resolveBodyOnly?: false;
}>;

export type ResponseBodyOnly = {
resolveBodyOnly: true;
};