This repository has been archived by the owner on Oct 2, 2024. It is now read-only.
[REFACTOR] Split models Fields and Vectors. #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-settings-models
frascuchon
force-pushed
the
refactor/split-settings-models
branch
from
cbbb12c
to
620cfd5
Compare
for more information, see https://pre-commit.ci
burtenshaw
reviewed
May 27, 2024
|
This looks like a good start. We could also work on this next: argilla-io/argilla#4931 |
burtenshaw
approved these changes
May 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Field models and vector models are separated classes. To keep aligned with the API definition