Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] Improve handling of question models and dicts #4931

Open
burtenshaw opened this issue May 21, 2024 · 1 comment
Open

[REFACTOR] Improve handling of question models and dicts #4931

burtenshaw opened this issue May 21, 2024 · 1 comment
Assignees
Labels
area: python sdk Indicates that an issue or pull request is related to the Python SDK type: refactor Indicates internal refactoring of the code-base
Milestone

Comments

@burtenshaw
Copy link
Contributor

We can improve code quality and reduce redunancy by using a pydnatic type annotator instead of identical methods on each cleas:

@frascuchon gives an example here: argilla-io/argilla-python#195 (comment)

@frascuchon
Copy link
Member

@burtenshaw This could be part of a wider issue to align questions to Resource class and finally allow update settings for questions

@nataliaElv nataliaElv transferred this issue from argilla-io/argilla-python Jun 4, 2024
@nataliaElv nataliaElv added this to the v2.0.0 milestone Jun 4, 2024
@frascuchon frascuchon self-assigned this Jun 4, 2024
@burtenshaw burtenshaw modified the milestones: v2.0.0, v2.1.0 Jun 5, 2024
@burtenshaw burtenshaw added the area: python sdk Indicates that an issue or pull request is related to the Python SDK label Jun 5, 2024
@frascuchon frascuchon modified the milestones: v2.1.0, v2.2.0 Aug 28, 2024
@frascuchon frascuchon added the type: refactor Indicates internal refactoring of the code-base label Sep 10, 2024
@frascuchon frascuchon modified the milestones: v2.2.0, v2.3.0 Sep 17, 2024
@frascuchon frascuchon modified the milestones: v2.3.0, v2.4.0 Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: python sdk Indicates that an issue or pull request is related to the Python SDK type: refactor Indicates internal refactoring of the code-base
Projects
None yet
Development

No branches or pull requests

3 participants