Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Hook commit contexts to GitHub PR/Issue labels #7

Closed
orta opened this issue Aug 29, 2017 · 3 comments
Closed

RFC: Hook commit contexts to GitHub PR/Issue labels #7

orta opened this issue Aug 29, 2017 · 3 comments

Comments

@orta
Copy link
Contributor

orta commented Aug 29, 2017

Proposal:

Let's say you had a commit like this:

screen shot 2017-08-29 at 13 52 20

Which is the commit the format used inside GMV. Peril should look through all of the existing labels for that repo and apply any that are used inside the commit message as a [Label] match.

Reasoning

This data already exists in issues and commits, so adding it here means less chore work.

Exceptions:

This won't fail builds, and is only additive - so no need for exceptions

@jonallured
Copy link
Member

Another thought here:

If we're going to teach Peril how to connect labels with commits, maybe we should get that data out of the commit subject line and put it into the body, something like this:

Add support for searching for a location

This commit adds support for searching for a location, which is a great feature. It was challenging to work on, but once I remembered to try hard and believe in myself the code sorta fell into place.

closes #12
labels: consignments

I guess what I'm saying is that if Peril can parse the commit message and apply labels, then getting that noise out of the subject line seems to have value to me. Just a thought!

@orta
Copy link
Contributor Author

orta commented Aug 29, 2017

http://i0.kym-cdn.com/photos/images/newsfeed/000/538/731/0fc.gif

@orta
Copy link
Contributor Author

orta commented Sep 17, 2017

I started this once: danger/danger-js#180 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants