-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Hook commit contexts to GitHub PR/Issue labels #7
Comments
Another thought here: If we're going to teach Peril how to connect labels with commits, maybe we should get that data out of the commit subject line and put it into the body, something like this:
I guess what I'm saying is that if Peril can parse the commit message and apply labels, then getting that noise out of the subject line seems to have value to me. Just a thought! |
I started this once: danger/danger-js#180 (comment) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Proposal:
Let's say you had a commit like this:
Which is the commit the format used inside GMV. Peril should look through all of the existing labels for that repo and apply any that are used inside the commit message as a
[Label]
match.Reasoning
This data already exists in issues and commits, so adding it here means less chore work.
Exceptions:
This won't fail builds, and is only additive - so no need for exceptions
The text was updated successfully, but these errors were encountered: