Implements RFC 7 #26
Merged
Implements RFC 7 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Strange, wonder why Peril didn't complain about no one being assigned to the PR? |
|
Ah, I see the failure in the logs. I'll try to take a look. |
|
Fixed that in #27. |
|
This is awesome - I'm into it for sure. My only hesitation is taking a step back and looking at |
|
There's a current limitation with peril that we can't require relative files, so we're stuck with a long file ATM |
|
Cool, going to merge, thanks @ashfurrow!! |
|
AWWWWWW YEAH |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7, based on this work from Orta. Possible addition: translate from shorthand to longhand labels (so a commit message like
[MSG] Implements inboxwould match theMessaginglabel. I'll take a look later today.There's probably some code golfing to do, so don't be shy about pointing out alternative syntax etc!