Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong handling of data pack backward compatibility #853

Closed
hunterhector opened this issue Jul 4, 2022 · 0 comments · Fixed by #854
Closed

Wrong handling of data pack backward compatibility #853

hunterhector opened this issue Jul 4, 2022 · 0 comments · Fixed by #854

Comments

@hunterhector
Copy link
Member

Describe the bug
Multipack supports a new way to support data pack index after a version (0.0.1), which
is firstly named PACK_ID_COMPATIBLE_VERSION.

However, this name is confusing
and is considered to be used to indicate the newest data pack version supported by
the current Forte version. In fact, the variable PACK_ID_COMPATIBLE_VERSION is
updated, hence the logic is wrong now. The version value used in this check should
not be changed.

Additional context
The PR that creates this check is: ac5b58f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant