Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data pack version documentation and a multipack check bug #854

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

hunterhector
Copy link
Member

This PR fixes #853.

Description of changes

  1. Fix the multipack version-check version
  2. Add documentation in version.py and update history.rst to record the data pack version compatibility

@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #854 (9011c01) into master (8b233e4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 9011c01 differs from pull request most recent head 64abe20. Consider uploading reports for the commit 64abe20 to get more accurate results

@@           Coverage Diff           @@
##           master     #854   +/-   ##
=======================================
  Coverage   80.73%   80.74%           
=======================================
  Files         254      254           
  Lines       19361    19362    +1     
=======================================
+ Hits        15632    15633    +1     
  Misses       3729     3729           
Impacted Files Coverage Δ
forte/version.py 100.00% <ø> (ø)
forte/data/multi_pack.py 82.19% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da5e6f4...64abe20. Read the comment docs.

@hunterhector hunterhector merged commit 115d03e into asyml:master Jul 5, 2022
@hunterhector hunterhector deleted the datapack_version branch December 20, 2022 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong handling of data pack backward compatibility
1 participant