Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove class objects from DataStore #898

Closed
mylibrar opened this issue Aug 23, 2022 · 0 comments · Fixed by #899
Closed

Remove class objects from DataStore #898

mylibrar opened this issue Aug 23, 2022 · 0 comments · Fixed by #899
Assignees

Comments

@mylibrar
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
DataStore should only store primitive types as well as built-in list or dict. However, we still find some class objects being stored into DataStore. These structures are usually not JSON serializable. We need to remove them and maybe add some conversion layer if necessary.

Describe the solution you'd like
Class objects to be removed from DataStore:

  • FNdArray: We will need to refactor FNdArray for conversion.
  • Span

Additional context

  • This is part of the data efficiency project
  • This PR should be made to the master branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant