Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove class objects from DataStore #899

Merged
merged 3 commits into from
Aug 31, 2022

Conversation

mylibrar
Copy link
Collaborator

@mylibrar mylibrar commented Aug 23, 2022

This PR fixes #898 .

Description of changes

  • Refactor FNdArray and add conversion layer to entry_getter and entry_setter in BasePack.on_entry_creation.
  • Remove deprecated image_annotations in DataPack.
  • Remove redundant __getstate__ and __setstate__ methods in Annotation and AudioAnnotation.
  • Serialize Span in replace_back_operations and processed_original_spans from Payload to make it JSON serializable.
  • Revert get_parent and get_child in MultiPackLink

Test Conducted

  • ndarray_attribute_test.py (test FNdArray conversion)
  • html_reader_test.py (test Span conversion)

@mylibrar mylibrar self-assigned this Aug 23, 2022
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #899 (8f8c319) into master (3ba5d8f) will increase coverage by 0.15%.
The diff coverage is 95.00%.

@@            Coverage Diff             @@
##           master     #899      +/-   ##
==========================================
+ Coverage   80.85%   81.00%   +0.15%     
==========================================
  Files         254      254              
  Lines       19607    19583      -24     
==========================================
+ Hits        15854    15864      +10     
+ Misses       3753     3719      -34     
Impacted Files Coverage Δ
forte/data/data_pack.py 85.07% <ø> (-0.03%) ⬇️
forte/data/base_pack.py 76.68% <85.71%> (+0.51%) ⬆️
forte/data/data_store.py 93.25% <100.00%> (+0.01%) ⬆️
forte/data/ontology/core.py 82.47% <100.00%> (+5.51%) ⬆️
forte/data/ontology/top.py 78.74% <100.00%> (+3.05%) ⬆️
forte/data/span.py 82.75% <100.00%> (+3.59%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

forte/data/ontology/core.py Show resolved Hide resolved
forte/data/ontology/core.py Outdated Show resolved Hide resolved
forte/data/ontology/top.py Outdated Show resolved Hide resolved
forte/data/base_pack.py Outdated Show resolved Hide resolved
@mylibrar mylibrar marked this pull request as draft August 24, 2022 18:50
@mylibrar mylibrar marked this pull request as ready for review August 24, 2022 20:27
@mylibrar mylibrar merged commit fe632e6 into asyml:master Aug 31, 2022
@mylibrar mylibrar deleted the remove-class-objects branch August 31, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove class objects from DataStore
3 participants