-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move texar to extra require #720
Move texar to extra require #720
Conversation
@feipenghe @mylibrar Please notice that the solution cannot be simply throwing exceptions at run time. If we decide Texar would be extra required, we need to provide a good extra requirement install option in Note that you also cannot simply say Here is the goal: the user shouldn't encounter any exception if he follows the documentation. The exceptions are pointers for a user to notice the documentation, not documentations by themselves. |
…enghe/forte into move_texar_to_extra_require
cd texar-pytorch | ||
pip install --progress-bar off . | ||
cd .. | ||
rm -rf texar-pytorch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why don't we run these steps before the Install Texar
or even the Install deep learning frameworks
step?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we still have dependencies on other libraries in the dependency matrix. In this PR, we only need to remove texar
. In the later PR that we set up a dependency env for different modules, these lines of code will be removed.
This PR fixes #719.
Description of changes
ImportError
with suggestions when the extra librarytexar-pytorch
is not installedPossible influences of this PR.
texar
functionsTest Conducted
texar_non_dependency_test.py
that imports classes that doesn't have dependency ontexar-pytorch
but might trigger importingtorch
accidentally through__init__.py
or importingtorch
at the head of class files.