-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move texar to extra require #720
Merged
hepengfe
merged 102 commits into
asyml:master
from
hepengfe:move_texar_to_extra_require
Apr 12, 2022
Merged
Changes from all commits
Commits
Show all changes
102 commits
Select commit
Hold shift + click to select a range
8a1bdfe
raise import error for texar-pytorch
hepengfe 5319775
raise import error for texar-pytorch
hepengfe 8d06d73
remove texar-pytorch requirement
hepengfe 0c3edda
Merge branch 'master' into move_texar_to_extra_require
hepengfe 6db52e1
Reverse test file changes
hepengfe 5de9914
fix HParams importing
hepengfe f976dcb
Merge branch 'move_texar_to_extra_require' of https:/feip…
hepengfe 757ba7d
change extra_require as suggested
hepengfe fb6dca1
rebase from master branch
hepengfe 19e8ed2
update pre-commit black version
hepengfe fea18a0
add description about updating pre-commit configuration
hepengfe 7e582d9
black
hepengfe aecc633
rm unrelevant files
hepengfe 63ac0d1
rm unrelevant files
hepengfe aa3a83a
Merge branch 'master' into move_texar_to_extra_require
hepengfe 374183b
edit based on code review
hepengfe a2282f9
add requirement of transformers for audio test
hepengfe 865fc6d
add pseudo hyperlink to point to the installation command
hepengfe 82d6722
pylint
hepengfe 24003f5
add extra requisite to main.yml
hepengfe 8c3daa6
spacing
hepengfe 46430dd
spacing
hepengfe 22880eb
try transformers 4.15.0
hepengfe adf3ff5
loosen requirement
hepengfe 66c0504
remove past requirement
hepengfe 6f1228f
Merge branch 'master' into move_texar_to_extra_require
hunterhector 893e84e
merge extra requirements
hepengfe 147dbf4
fixed hyperlink in README.md
hepengfe 0c3f509
fixed hyperlink title
hepengfe b748ed7
imports in the local scope and re-raise import error with error messages
hepengfe 9c24693
remove modules from __init__
hepengfe b5d44a0
Merge branch 'master' into move_texar_to_extra_require
hepengfe e863d53
pylint
hepengfe 9cc6d18
pylint
hepengfe 839ea76
Merge branch 'master' into move_texar_to_extra_require
hepengfe 58a4f4c
adjust imports in test files
hepengfe 84aac86
HParams from asyml_utilities
hepengfe db0b32d
workflow edit
hepengfe e2bafe0
readthedocs asyml_utilities
hepengfe 414be53
import special tokens from asyml_utilities
hepengfe 9f4b265
move ImportError out of the loop
hepengfe 24df884
fix import orders
hepengfe 925b585
move out many more texar dependency
hepengfe 5cb4eb1
add train preprocessor
hepengfe 612b647
add train preprocessor
hepengfe ffec8dc
update main.yml
hepengfe 4a46987
fix rst files
hepengfe 0db66b3
pylint
hepengfe 7392216
git add tests
hepengfe 1498d64
special tokens
hepengfe 5c98ff0
Fix test importing
hepengfe 1cc9c3b
special tokens
hepengfe fa8b468
pylint
hepengfe 203825b
Update data_pack_dataset.py
hunterhector 1821670
Update README.md
hunterhector 33da833
Update setup.py
hunterhector befffb3
Update main.yml
hunterhector 8ae4cea
Update tagging_trainer.py
hunterhector 7f464a2
Update __init__.py
hunterhector 5aa2ce1
Update bert_based_query_creator.py
hunterhector dc30347
Update bert_ranker.py
hunterhector 73ae361
Update bert_reranking_processor.py
hunterhector baed126
Update srl_predictor.py
hunterhector 66598b1
Update data.py
hunterhector 2d8bdf3
Update model.py
hunterhector e296cea
Update model_utils.py
hunterhector a9a3422
Update data.py
hunterhector 166f473
Update model.py
hunterhector 85ec72e
Update model_utils.py
hunterhector e2ba106
Update model_factory.py
hunterhector c7d2b4d
Update __init__.py
hunterhector eeb96cf
Update train_preprocessor.py
hunterhector 1cefd81
Update main.yml
hunterhector ac074de
Update setup.py
hunterhector 06df5e2
Update subword_tokenizer.py
hunterhector df6e745
Update README.md
hunterhector c7c5473
Update texar_nondependency_test.py
hunterhector b974eeb
Update main.yml
hunterhector 7f7b37f
Update bert_ranker.py
hunterhector 621046f
Update bert_ranker.py
hunterhector 9b52a08
move texar dependent SRLSpanData out
hepengfe eee4c9c
merge requirement of texar encoder into nlp
hepengfe d2312c4
srl span data
hepengfe f3ddb81
udpate readme
hepengfe 9d96d69
add temporary torch installation
hepengfe 87619a6
uninstall texar pytorch after installing forte
hepengfe cfb5856
uninstall without prompt
hepengfe b8a0ae1
pylint
hepengfe 10e3008
pylint
hepengfe 08692c9
update texar pytorch version requirement
hepengfe 99e7592
ignore texar nondependency test in coverage run
hepengfe 01753e3
install the lastest texar pytorch
hepengfe 9bc13d2
add texar related test cases
hepengfe fa03088
Merge branch 'master' into move_texar_to_extra_require
hepengfe 8ae2547
move bert classes depedent on texar inside the folder
hepengfe f3e5d15
move bert classes depedent on texar inside the folder
hepengfe 7f15ae7
ir bert paths
hepengfe 0e1359e
fixed hyperlinks
hepengfe 0a24224
pylint
hepengfe baacbe4
remove unrelevant tests
hepengfe 4e4155e
Merge branch 'master' into move_texar_to_extra_require
hepengfe 1c35c60
Merge branch 'master' into move_texar_to_extra_require
hepengfe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -168,4 +168,4 @@ | |
}, | ||
"nbformat": 4, | ||
"nbformat_minor": 1 | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why don't we run these steps before the
Install Texar
or even theInstall deep learning frameworks
step?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we still have dependencies on other libraries in the dependency matrix. In this PR, we only need to remove
texar
. In the later PR that we set up a dependency env for different modules, these lines of code will be removed.