feat: adapt Kafka bindings to v3 - take 2 #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laurent Broudoux <[email protected]>
dalelane
reviewed
Nov 26, 2023
dalelane
previously approved these changes
Nov 26, 2023
|
As we are preparing to merge #224 ASAP, do you folks want to have this included or want to re-target the PR after merge? 😄 |
|
sorry - I'd missed that the merge had dismissed my review |
comment was copy/pasted from elsewhere in the file and isn't relevant for the example it's next to
dalelane
previously approved these changes
Dec 3, 2023
dalelane
reviewed
Dec 3, 2023
dalelane
reviewed
Dec 3, 2023
|
@lbroudoux I think some indenting needs an update - I've put suggestions in. Do they look okay? |
|
@dalelane Ok for the 2 suggested changes and I found some others that were also bad. Sorry for the mistakes and thanks for your vigilance. I think we're good to go now. |
dalelane
approved these changes
Dec 4, 2023
|
I needed to merge with the upstream branch to resolve a conflict |
|
/rtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue(s)
Relates to #182