Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adapt Kafka bindings to v3 - take 2 #226

Merged
merged 6 commits into from
Dec 4, 2023
Merged

feat: adapt Kafka bindings to v3 - take 2 #226

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
77b14e7
feat: adapt Kafka bindings to v3 - take 2
lbroudoux Nov 24, 2023
fdec866
Merge branch 'next-major-spec' into move-kafka-bindings-v3
lbroudoux Nov 26, 2023
a8024f0
fix: remove duplicated comment
dalelane Dec 3, 2023
031f965
Fix indentations when moving Kafka bindings to v3
lbroudoux Dec 3, 2023
ea459ae
Fix indentation when moving Kafka bindings to v3
lbroudoux Dec 3, 2023
ca0c3a1
Merge branch 'next-major-spec' into move-kafka-bindings-v3
dalelane Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 20 additions & 18 deletions kafka/README.md
View file
Open in desktop
dalelane marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,6 @@ This object MUST contain only the properties defined above.

##### Example

This example is valid for any Confluent compatible schema registry. Here we describe the implementation using the first 4 bytes in payload to store schema identifier.

```yaml
channels:
user-signedup:
Expand Down Expand Up @@ -122,16 +120,18 @@ This object MUST contain only the properties defined above.
```yaml
channels:
user-signedup:
subscribe:
bindings:
kafka:
groupId:
type: string
enum: ['myGroupId']
clientId:
type: string
enum: ['myClientId']
bindingVersion: '0.4.0'
operations:
userSignup:
action: receive
bindings:
kafka:
groupId:
type: string
enum: ['myGroupId']
clientId:
type: string
enum: ['myClientId']
bindingVersion: '0.4.0'
```


Expand All @@ -158,8 +158,9 @@ This example is valid for any Confluent compatible schema registry. Here we desc
```yaml
channels:
test:
publish:
message:
address: test-topic
messages:
testMessage:
bindings:
kafka:
key:
Expand All @@ -175,8 +176,9 @@ This is another example that describes the use if Apicurio schema registry. We d
```yaml
channels:
test:
publish:
message:
address: test-topic
messages:
testMessage:
bindings:
kafka:
key:
Expand All @@ -188,5 +190,5 @@ channels:
bindingVersion: '0.4.0'
```

[schemaObject]: https://www.asyncapi.com/docs/specifications/2.4.0/#schemaObject
[referenceObject]: https://www.asyncapi.com/docs/specifications/2.4.0/#referenceObject
[schemaObject]: https://www.asyncapi.com/docs/reference/specification/v3.0.0-next-major-spec.15#schemaObject
[referenceObject]: https://www.asyncapi.com/docs/reference/specification/v3.0.0-next-major-spec.15#referenceObject