Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: adapt components to parser-api #586

Merged
merged 6 commits into from
Sep 1, 2022

Conversation

smoya
Copy link
Member

@smoya smoya commented Aug 31, 2022

Description

This PR updates the Components model with latest changes from asyncapi/parser-api#71.
This PR does not add either SecurityRequirement, or SecurityRequirements, which will be added in a separate PR.

Related issue(s)
#482

Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! :) I found some things that we can improve, but they aren't bugs.

src/models/v2/channel.ts Outdated Show resolved Hide resolved
src/models/v2/channel.ts Outdated Show resolved Hide resolved
src/models/v2/channel.ts Outdated Show resolved Hide resolved
src/models/v2/components.ts Outdated Show resolved Hide resolved
smoya and others added 4 commits August 31, 2022 19:58
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@magicmatatjahu
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit b5ce5d9 into asyncapi:next-major Sep 1, 2022
magicmatatjahu pushed a commit to magicmatatjahu/parser-js that referenced this pull request Oct 3, 2022
derberg pushed a commit that referenced this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants