Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add migration guide #789

Merged
merged 13 commits into from
Jun 26, 2023
Merged

docs: add migration guide #789

merged 13 commits into from
Jun 26, 2023

Conversation

jonaslagoni
Copy link
Member

Description
This PR finishes #611

@jonaslagoni jonaslagoni changed the title docs: adapt main readme and add migration guide docs: add migration guide Jun 14, 2023
smoya
smoya reviewed Jun 20, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
jonaslagoni
jonaslagoni commented Jun 20, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
smoya
smoya reviewed Jun 20, 2023
View reviewed changes
docs/migrations/v1-to-v2.md Outdated Show resolved Hide resolved
@jonaslagoni jonaslagoni requested a review from smoya June 20, 2023 12:24
smoya
smoya requested changes Jun 20, 2023
View reviewed changes
docs/migrations/v1-to-v2.md Outdated Show resolved Hide resolved
docs/migrations/v1-to-v2.md Outdated Show resolved Hide resolved
docs/migrations/v1-to-v2.md Outdated Show resolved Hide resolved
@jonaslagoni
Copy link
Member Author

Think I solved both your comments (including #789 (comment)) @smoya let me know if not 😄

@jonaslagoni jonaslagoni requested a review from smoya June 20, 2023 12:58
smoya
smoya previously approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀🌔

@jonaslagoni
Copy link
Member Author

@smoya can you disable sonarcloud required check 🙂

@jonaslagoni
Copy link
Member Author

Or merge it manually.

@smoya
Copy link
Member

smoya commented Jun 26, 2023

@smoya can you disable sonarcloud required check 🙂

I think I can't. The issue is with duplicated lines. TBH I don't really understand why the analysis is not limited to the changes added in the PR...

I can't manually merge it either 🤷
Google Chrome_OltFSYoB

@jonaslagoni
Copy link
Member Author

Cc admin @derberg

@derberg
Copy link
Member

derberg commented Jun 26, 2023

I think it is all about tests and it is completely fine if you just add sonar.exclusions=test/**/* to https:/asyncapi/parser-js/blob/master/.sonarcloud.properties

@sonarcloud
Copy link

sonarcloud bot commented Jun 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.2% 1.2% Duplication

@jonaslagoni jonaslagoni requested a review from smoya June 26, 2023 19:42
@jonaslagoni jonaslagoni merged commit c6f0a10 into asyncapi:master Jun 26, 2023
@jonaslagoni
Copy link
Member Author

Thanks @smoya 👍

@jonaslagoni jonaslagoni deleted the migration_guide branch June 26, 2023 21:33
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0-next-major-spec.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoya smoya smoya approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@derberg derberg Awaiting requested review from derberg

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
released on @next-major-spec released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonaslagoni @smoya @derberg @asyncapi-bot