Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add migration guide #611

Closed

Conversation

magicmatatjahu
Copy link
Member

@magicmatatjahu magicmatatjahu commented Sep 14, 2022

Description

Add migration guide v1 -> v2.

Some sections will have to be updated before release.

cc @smoya @jonaslagoni @derberg @fmvilas

Related issue(s)
Part of #481
Part of #482

smoya and others added 30 commits February 11, 2022 12:21
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Apr 23, 2023
@smoya
Copy link
Member

smoya commented Apr 24, 2023

Still relevant. cc @magicmatatjahu

@github-actions github-actions bot removed the stale label Apr 25, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@smoya
Copy link
Member

smoya commented May 4, 2023

@magicmatatjahu you need to change the base branch to be master now since the Parser has been merged.

@magicmatatjahu magicmatatjahu changed the base branch from next-major to master May 4, 2023 06:35
@magicmatatjahu magicmatatjahu dismissed fmvilas’s stale review May 4, 2023 06:35

The base branch was changed.

@smoya
Copy link
Member

smoya commented May 4, 2023

@magicmatatjahu After changing base branch to master, now it has conflicts. I think the best is to just reset --hard to the HEAD of master and do cherry-pick of the commit(s) that adds the migration guide.

@jonaslagoni
Copy link
Member

jonaslagoni commented Jun 14, 2023

This really should have been resolved before we released v2 of the parser.

@jonaslagoni
Copy link
Member

Re-creating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants