fix build with Xcode 16 by disabling InternalImportsByDefault
#115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`InternalImportsByDefault` makes all imports `internal` by default. This means that none of those imports can be used in public interfaces. Currently this repo _is_ using lots of `internal imports` and it seems like the feature is ignored in Xcode 15. On Xcode 16 this breaks expectingly. I'm not 100% clear on how the transition to this feature will work, and if the feature can only be enabled once everyone's building with Xcode 16? Disabling the feature now and adding a comment to get the Xcode 16 build to work.
|
I've opened #116 as an alternative, because I would like to track this through to a fully Swift6 compliant mode. If there's something in there that breaks a build with Xcode 16, please try it out and give me feedback on the PR |
Ah, sweet! I wasn't sure if the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InternalImportsByDefaultmakes all importsinternalby default. This means that none of those imports can be used in public interfaces.Currently this repo is using lots of
internal importsand it seems like the feature is ignored in Xcode 15. Building on Xcode 16 breaks as expected.I'm not 100% clear on how the transition to this feature will work, and if the feature can only be enabled once everyone's building with Xcode 16?
Disabling the feature now and adding a comment to make builds work with Xcode 16 (beta 3)