Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build with Xcode 16 by disabling InternalImportsByDefault #115

Commits on Jul 22, 2024

  1. fix build with Xcode 16 by disabling InternalImportsByDefault

    `InternalImportsByDefault` makes all imports `internal` by default.
    This means that none of those imports can be used in public interfaces.
    Currently this repo _is_ using lots of `internal imports` and it seems
    like the feature is ignored in Xcode 15. On Xcode 16 this breaks expectingly.
    
    I'm not 100% clear on how the transition to this feature will work, and
    if the feature can only be enabled once everyone's building with Xcode 16?
    
    Disabling the feature now and adding a comment to get the Xcode 16 build
    to work.
    diederich committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    14fd35e View commit details
    Browse the repository at this point in the history