Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(iotevents-actions): Add missing actions #22504

Open
1 of 2 tasks
azatoth opened this issue Oct 14, 2022 · 3 comments
Open
1 of 2 tasks

(iotevents-actions): Add missing actions #22504

azatoth opened this issue Oct 14, 2022 · 3 comments
Labels
@aws-cdk/aws-iotevents-actions effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3

Comments

@azatoth
Copy link
Contributor

azatoth commented Oct 14, 2022

Describe the feature

At the moment, we are exposing:
ClearTimerAction
LambdaInvokeAction
ResetTimerAction
SetTimerAction
SetVariableAction
TimerDuration

What are missing from DetectorModel and AlarmModel are following:

  • DynamoDB
  • DynamoDbv2
  • Firehose
  • IotEvents
  • IotSiteWise
  • IotTopicPublic
  • Sns
  • Sqs

Use Case

To allow users to use these actions vi L2 constructs.

Proposed Solution

Should be similar to how the current actions are implemented.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.46.0

Environment details (OS name and version, etc.)

Linux

@azatoth azatoth added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 14, 2022
@peterwoodworth peterwoodworth added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Oct 18, 2022
@peterwoodworth
Copy link
Contributor

We'd love to support the rest of the available action @azatoth, thanks for the suggestion.

I am marking this issue as p2, which means that we are unable to work on this immediately.

Check out our contributing guide if you're interested in contributing yourself - there's a low chance the team will be able to address this soon but we'd be happy to review a PR 🙂

@azatoth
Copy link
Contributor Author

azatoth commented Oct 18, 2022

We'd love to support the rest of the available action @azatoth, thanks for the suggestion.

I assume you meant to link to https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-iotevents-detectormodel-action.html as we are referring to IoTEvents actions, and currently only actions for the DetectorModel. I assume a redesign of how actions are contained might need to be addressed if/when AlarmModel (#22502) gets implemented, as they don't have the exact same set of actions.

Check out our contributing guide if you're interested in contributing yourself - there's a low chance the team will be able to address this soon but we'd be happy to review a PR slightly_smiling_face

Yea I was looking into it, but got confused about the "Design" section, which seems to indicate an accepted RFC is required for any L2 implementation.

@azatoth
Copy link
Contributor Author

azatoth commented Oct 21, 2022

Yea I was looking into it, but got confused about the "Design" section, which seems to indicate an accepted RFC is required for any L2 implementation.

I filed a ticket for that in #22601

@Naumel Naumel removed their assignment Jun 28, 2023
@pahud pahud added p3 and removed p2 labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-iotevents-actions effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3
Projects
None yet
Development

No branches or pull requests

4 participants