-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unclear sentence under "Design" section in CONTRIBUTION.md
#22601
Comments
Thanks for letting us know about this section @azatoth, I agree that it's unclear and misleading. I'm not sure that the RFC rule is strict about needing a new RFC for every individual new L2 construct. That could be obstructive more than constructive in some cases, like for each new IOT action we can add and other similar constructs. I'd imagine that at the very least for this case we would only need to approve an RFC for an arbitrary action rather than an RFC for every individual action. Looking at these actions, it doesn't seem there was an RFC at all but rather discussion went on in the initial reported issue with a team member. So I wouldn't be worried about trying to contribute more actions in this case. We will figure out how to make our requirements much more clear soon and then update the guide 🙂 |
we'll be updating this soon. Closing now so that this issue doesn't linger unnecessarily, thanks for reporting |
|
Describe the issue
Currently, for the section "Step 2: Design" (also marked as "optional" in the TOC);
It contains the following paragraphs:
The main issue I see is that the last sentence "L2 construct implementation pull requests will not be reviewed without linking an approved RFC" are:
I would suggest to drop this language altogether.
Links
https:/aws/aws-cdk/blob/main/CONTRIBUTING.md#step-2-design
The text was updated successfully, but these errors were encountered: