feat(core): add validations for export name in CfnOutput

[go-to-k]

Closes #28563.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[go-to-k]

Exemption Request: This PR just adds validations, so unit tests could cover them.

[laurelmay]

The implementation looks good to me, though I do wonder if this is more of a bugfix along the lines of:

fix(core): CfnOutput does not validate export name

[go-to-k]

@kylelaker
Thanks for your review!
Recently, I often look to get the title of PRs for validation additions corrected to feat, so I'm using feat again. Do you think it should be changed?

#28529
#28316
#27592
#27124
#26241

[laurelmay]

@kylelaker Thanks for your review! Recently, I often look to get the title of PRs for validation additions corrected to feat, so I'm using feat again. Do you think it should be changed?

Oh interesting! Never mind my suggestion then! Thanks for highlighting that; I didn't know that validation additions were being tracked as features. Makes sense to me either way (though I guess it's possibly a little odd that these validation features will basically always need an exemption since there isn't often a README or integration test that makes sense here...) but I won't disagree with the core team when it comes to naming 😄 Thanks for highlighting those previous PRs and I'll try to follow that pattern myself in the future.

Thanks for adding these new validations for CfnOutput!

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[gracelu0]

Thank you for your contribution, we appreciate it! In the future it would be helpful to include a brief description for the PR as well - makes it a bit easier for us to review :)

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[go-to-k]

@gracelu0

Thanks for the approval. The merge failed with Mergify / Queue: Embarked in merge queue. Could you please handle this again?

Pull request has been modified.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: a131e1d
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).