Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add validations for export name in CfnOutput #28575

Merged
merged 8 commits into from
Jan 23, 2024
Merged

feat(core): add validations for export name in CfnOutput #28575

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2c82837
feat(core): add validation for export name in CfnOutput
go-to-k Jan 4, 2024
5f2912d
add unit tests
go-to-k Jan 4, 2024
bc1ddc8
modify valid-templates.test.ts in aws-cdk-lib/cloudformation-include
go-to-k Jan 4, 2024
ddc6126
Merge branch 'main' into cfn-output-export-name-validation
go-to-k Jan 4, 2024
62b2f74
change logic
go-to-k Jan 5, 2024
29144ae
Update packages/aws-cdk-lib/core/test/output.test.ts
go-to-k Jan 5, 2024
6198bc7
Merge branch 'main' into cfn-output-export-name-validation
gracelu0 Jan 23, 2024
a131e1d
Merge branch 'main' into cfn-output-export-name-validation
mergify[bot] Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/aws-cdk-lib/core/lib/cfn-output.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,16 @@ export class CfnOutput extends CfnElement {
}

private validateOutput(): string[] {
if (this._exportName && !Token.isUnresolved(this._exportName) && this._exportName.length > 255) {
return [`Export name cannot exceed 255 characters (got ${this._exportName.length} characters)`];
if (this._exportName !== undefined && !Token.isUnresolved(this._exportName)) {
if (this._exportName.length === 0) {
return ['Export name cannot be empty'];
}
if (this._exportName.length > 255) {
return [`Export name cannot exceed 255 characters (got ${this._exportName.length} characters)`];
}
if (!/^[A-Za-z0-9-:]*$/.test(this._exportName)) {
return [`Export name must only include alphanumeric characters, colons, or hyphens (got '${this._exportName}')`];
}
}
return [];
}
Expand Down
Loading