Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add yasumi creation by ISO3166-2 code #61

Closed
huehnerhose opened this issue May 31, 2017 · 2 comments
Closed

add yasumi creation by ISO3166-2 code #61

huehnerhose opened this issue May 31, 2017 · 2 comments
Labels
enhancement
Milestone
v1.7.0

Comments

@huehnerhose
Copy link
Contributor

huehnerhose commented May 31, 2017 •
edited
Loading

I want to get holidays based on dynamically gathered region informations. The ISO3166-2 codes I can get out of various map-api.
As far as I can see the const ID inside the providers corresponce to ISO3166-2 and is used as index for the getProviders() return array.

Therefore I made a simple wrapper. There aren't any test for this wrapper implemented and I only "tested" it against my usage. (Germany and Subdivisions of Germany).

So this is kind of a "Feature Request" / "Pull Request" mix :)
@stelgenhof
Copy link
Member

Very nice! Some others have asked a similar feature as currently you need to know the exact name of the Holiday provider. Would you be able to create a PR?

@huehnerhose huehnerhose mentioned this issue Jun 6, 2017
Merged
@stelgenhof
Copy link
Member

Closing issue. Resolved by PR #62

@stelgenhof stelgenhof added this to the v1.7.0 milestone Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1.7.0
Development

No branches or pull requests
2 participants
@stelgenhof @huehnerhose