add yasumi creation by ISO3166-2 code #62
Conversation
src/Yasumi/Yasumi.php
Outdated
| { | ||
| $providers = self::getProviders(); | ||
|
|
||
| $class = isset($providers[$iso3166_2]) |
There was a problem hiding this comment.
You can simplify this by combining this and the 'if ($class === false)' into one. Then no need for the intermediate variable $class and ternary check.
There was a problem hiding this comment.
This one I am not sure about.
I can see that the assign of $providers is kind of unnecessary since the getProviders uses a static internal variable preventing the repetitive directory scanning.
But I am not convinced that something like:
if ( false === isset( self::getProviders()[$iso3166_2] ) ) {
throw new InvalidArgumentException(sprintf('Unable to find holiday provider by ISO3166-2 "%s".', $iso3166_2));
}
return self::create(
self::getProviders()[$iso3166_2],
$year,
$locale
);
benefits the readability of the code
There was a problem hiding this comment.
Yes, I see what you mean. What about this way:
$providers = self::getProviders();
if ( false === isset( $providers[$iso3166_2] ) ) {
throw new InvalidArgumentException(sprintf('Unable to find holiday provider by ISO3166-2 "%s".', $iso3166_2));
}
return self::create(
$providers[$iso3166_2],
$year,
$locale
);
src/Yasumi/Yasumi.php
Outdated
| * @throws RuntimeException If no such holiday provider is found | ||
| * @throws InvalidArgumentException if the year parameter is not between 1000 and 9999 | ||
| * @throws UnknownLocaleException if the locale parameter is invalid | ||
| * @throws InvalidArgumentException if the holiday provider for the given country does not exist |
There was a problem hiding this comment.
This needs to be corrected as the parameter is not 'country' but 'ISO3166-2'.
| @@ -186,6 +186,44 @@ public static function create($class, $year = null, $locale = self::DEFAULT_LOCA | |||
| } | |||
|
|
|||
| /** | |||
| * Create a new holiday provider instance. | |||
| * | |||
| * A new holiday provider instance can be created using this function. You can use one of the providers included | |||
There was a problem hiding this comment.
This description needs to be edited since this function is using the 'ISO3166-2' code as the input parameter.
See issue
I needed the option to create a yasumi instance by ISO3166-2 Code. As far as I can see, the
const IDin the providers corresponces to this code. Therefore I created this simple wrapper.I wasn't able to create test etc. for this wrapper. I think this should be added before mergen