Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revendoring all crates is broken #2752

Closed
criemen opened this issue Jul 19, 2024 · 1 comment · Fixed by #2768
Closed

Revendoring all crates is broken #2752

criemen opened this issue Jul 19, 2024 · 1 comment · Fixed by #2768

Comments

@criemen
Copy link
Contributor

criemen commented Jul 19, 2024

When trying to fix the CI on #2751, I ran the vendor.sh script, but it doesn't work on my computer:

 criemen@Corneliuss-MBP  ~/repos/rules_rust   label-fix ±  crate_universe/tools/vendor.sh                                   
Vendoring all targets in workspace .
INFO: Analyzed target //bindgen/3rdparty:crates_vendor (116 packages loaded, 364 targets configured).
INFO: Found 1 target...
Target //bindgen/3rdparty:crates_vendor up-to-date:
  bazel-bin/bindgen/3rdparty/crates_vendor.sh
INFO: Elapsed time: 29.905s, Critical Path: 0.00s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
INFO: Running command line: bazel-bin/bindgen/3rdparty/crates_vendor.sh

error: failed to parse manifest at `/tmp/.tmpnr2jfK/Cargo.toml`

Caused by:
  dependency (clang-sys) specified without providing a local path, Git repository, version, or workspace dependency to use

Error: Failed to run cargo tree: exit status: 101

It's on macos, with bazel 7.2.1.

@illicitonion
Copy link
Collaborator

Sorry about this! #2768 should fix this issue, and #2769 consolidates our two "repin all the things" scripts into one.

@illicitonion illicitonion self-assigned this Jul 29, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 30, 2024
I don't know how this ever worked before. I've picked the version that
happens to be in the lockfile at the moment.

Fixes #2752
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants