crate_universe: Only compile label regex once. #2751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can someone please push the correct, re-vendored dependencies here? I spent now 30min trying to get this to work locally, but it's not working for me. |
|
Revendoring the dependencies helped with some CI jobs, but the BCR jobs still complain about a lockfile being out of date. I ran the suggested command locally in |
UebelAndre
requested changes
Jul 31, 2024
There was a problem hiding this comment.
Thank you for this! I think there are some extra things you'll need manually to update on the bzlmod side of this. See #2368
I hit this when profiling for something else, we spent 1.1sec of 1.3sec of `cargo-bazel generate` compiling this regular expression. It seems to be quite bad on the regex compiler, as even compiling it once takes 8ms.
|
Thanks! CI finally passed on this. |
UebelAndre
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit this when profiling for something else, we spent 1.1sec of 1.3sec of
cargo-bazel generatecompiling this regular expression. It seems to be quite bad on the regex compiler, as even compiling it once takes 8ms.I had to add the
once_cellcrate to unwrap the Result type - the corresponding stdlib function is still nightly-only unfortunately. However, that crate was already in the transitive dependency tree, so it's a net-same change.