Skip to content

Commit

Permalink
Rename functions and variables to follow code style (#10961)
Browse files Browse the repository at this point in the history
# Objective

- Make more functions and variables in Javascript files follow the JS
naming convention

## Solution

- Rename functions and variables.
  • Loading branch information
tygyh authored Dec 13, 2023
1 parent 195ae08 commit 7a42e9d
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions .github/start-wasm-example/tests/wasm_example.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,19 @@ test.beforeEach(async ({ page }) => {
const MAX_TIMEOUT_FOR_TEST = 300_000;

test.describe('WASM example', () => {
test('Wait for success', async ({ page }, test_info) => {
test('Wait for success', async ({ page }, testInfo) => {
let start = new Date().getTime();

let found = false;
while (new Date().getTime() - start < MAX_TIMEOUT_FOR_TEST) {
let msg = await promise_with_timeout(100, on_console(page), "no log found");
let msg = await promiseWithTimeout(100, onConsole(page), "no log found");
if (msg.includes("no log found")) {
continue;
}
console.log(msg);
if (msg.includes("Test successful")) {
let prefix = process.env.SCREENSHOT_PREFIX === undefined ? "screenshot" : process.env.SCREENSHOT_PREFIX;
await page.screenshot({ path: `${prefix}-${test_info.project.name}.png`, fullPage: true });
await page.screenshot({ path: `${prefix}-${testInfo.project.name}.png`, fullPage: true });
found = true;
break;
}
Expand All @@ -30,20 +30,20 @@ test.describe('WASM example', () => {

});

function on_console(page) {
function onConsole(page) {
return new Promise(resolve => {
page.on('console', msg => resolve(msg.text()));
});
}

async function promise_with_timeout(time_limit, task, failure_value) {
async function promiseWithTimeout(timeLimit, task, failureValue) {
let timeout;
const timeout_promise = new Promise((resolve, reject) => {
const timeoutPromise = new Promise((resolve, reject) => {
timeout = setTimeout(() => {
resolve(failure_value);
}, time_limit);
resolve(failureValue);
}, timeLimit);
});
const response = await Promise.race([task, timeout_promise]);
const response = await Promise.race([task, timeoutPromise]);
if (timeout) {
clearTimeout(timeout);
}
Expand Down

0 comments on commit 7a42e9d

Please sign in to comment.