Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename functions and variables to follow code style #10961

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Rename functions and variables to follow code style #10961

merged 1 commit into from
Dec 13, 2023

Conversation

tygyh
Copy link
Contributor

@tygyh tygyh commented Dec 13, 2023

Objective

  • Make more functions and variables in Javascript files follow the JS naming convention

Solution

  • Rename functions and variables.

@matiqo15 matiqo15 added A-Build-System Related to build systems or continuous integration C-Code-Quality A section of code that is hard to understand or change O-Web Specific to web (WASM) builds labels Dec 13, 2023
ItsDoot
ItsDoot approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@ItsDoot ItsDoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed one here: https:/bevyengine/bevy/pull/10961/files#diff-af27b20db77d3641e673123088469216460c6eb0832ea5faebb8cd3fbb4326e6L10

Looks good otherwise.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 13, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 13, 2023
Merged via the queue into bevyengine:main with commit 7a42e9d Dec 13, 2023
22 checks passed
@tygyh tygyh deleted the Fix-naming branch December 15, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aceeri Aceeri Aceeri approved these changes

@ItsDoot ItsDoot ItsDoot approved these changes

@B-Reif B-Reif B-Reif approved these changes

@tim-blackbird tim-blackbird tim-blackbird approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Code-Quality A section of code that is hard to understand or change O-Web Specific to web (WASM) builds S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tygyh @Aceeri @ItsDoot @B-Reif @tim-blackbird @alice-i-cecile @matiqo15