Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix webgl2 crash #10053

Merged
merged 1 commit into from
Oct 8, 2023
Merged

fix webgl2 crash #10053

merged 1 commit into from
Oct 8, 2023

Conversation

Elabajaba
Copy link
Contributor

@Elabajaba Elabajaba commented Oct 8, 2023 •
edited
Loading

Objective

Webgl2 broke when pcf was merged.

Fixes #10048

Solution

Change the textureSampleCompareLevel in shadow_sampling.wgsl to textureSampleCompare to make it work again.

@mockersf mockersf added A-Rendering Drawing game state to the screen O-WebGL2 Specific to the WebGL2 render API labels Oct 8, 2023
@mockersf
Copy link
Member

mockersf commented Oct 8, 2023

Change the textureSampleCompare in shadow_sampling.wgsl to textureSampleCompareLevel to make it work again.

Isn't it the other way around?

@alice-i-cecile alice-i-cecile added this to the 0.12 milestone Oct 8, 2023
@Elabajaba
Copy link
Contributor Author

Elabajaba commented Oct 8, 2023 •
edited
Loading

Change the textureSampleCompare in shadow_sampling.wgsl to textureSampleCompareLevel to make it work again.

Isn't it the other way around?

Yup, fixed

superdump
superdump approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@superdump superdump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't make sense, but apparently works.

@superdump superdump added this pull request to the merge queue Oct 8, 2023
Merged via the queue into bevyengine:main with commit 78e4bb2 Oct 8, 2023
24 checks passed
regnarock pushed a commit to regnarock/bevy that referenced this pull request Oct 13, 2023
@Elabajaba
fix webgl2 crash (bevyengine#10053)
6be65b9 
# Objective

Webgl2 broke when pcf was merged.

Fixes bevyengine#10048

## Solution

Change the `textureSampleCompareLevel` in shadow_sampling.wgsl to
`textureSampleCompare` to make it work again.
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
@Elabajaba @ameknite
fix webgl2 crash (bevyengine#10053)
16cd7be 
# Objective

Webgl2 broke when pcf was merged.

Fixes bevyengine#10048

## Solution

Change the `textureSampleCompareLevel` in shadow_sampling.wgsl to
`textureSampleCompare` to make it work again.
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@Elabajaba
fix webgl2 crash (bevyengine#10053)
34a270a 
# Objective

Webgl2 broke when pcf was merged.

Fixes bevyengine#10048

## Solution

Change the `textureSampleCompareLevel` in shadow_sampling.wgsl to
`textureSampleCompare` to make it work again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superdump superdump superdump approved these changes

@mockersf mockersf mockersf approved these changes

@JMS55 JMS55 Awaiting requested review from JMS55

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen O-WebGL2 Specific to the WebGL2 render API
Projects
None yet
Milestone
0.12
Development

Successfully merging this pull request may close these issues.

StandardMaterial doesn't work in webgl2 on Windows with DX12
4 participants
@Elabajaba @mockersf @superdump @alice-i-cecile