Rephrase comment about Local<T> for clarity. #10322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
tim-blackbird
approved these changes
Oct 30, 2023
alice-i-cecile
approved these changes
Oct 31, 2023
alice-i-cecile
added
A-ECS
alice-i-cecile
added
the
S-Ready-For-Final-Review
alice-i-cecile
changed the title
@maueroats looks like CI failed on the formatting. I'd probably split it like: // Sometimes systems need to be stateful. Bevy's ECS provides the `Local` system parameter
// for this case. A `Local<T>` refers to a value of type `T` that is owned by the system.
// This value is automatically initialized using `T`'s `FromWorld`* implementation.
// In this system's `Local` (`counter`), `T` is `u32`.
// Therefore, on the first turn, `counter` has a value of 0.Swap to that, then run |
mnmaita
approved these changes
Nov 1, 2023
alice-i-cecile
added
the
S-Adopt-Me
|
merged in #11129 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
# Objective - Finish PR #10322 ## Solution - Rebase changes in PR #10322 and format the changes. Co-authored-by: Mauer-Oats <[email protected]>
tjamaan
pushed a commit
to tjamaan/bevy
that referenced
this pull request
Feb 6, 2024
) # Objective - Finish PR bevyengine#10322 ## Solution - Rebase changes in PR bevyengine#10322 and format the changes. Co-authored-by: Mauer-Oats <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The English phrasing originally made it sound like the system had type T.
Solution
Changing the word order fixed that.