Rephrase comment about Local<T> for clarity. (Adopted) #11129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tygyh
force-pushed
the
patch-2
branch
5 times, most recently
from
f88b290
to
57294d2
Compare
matiqo15
added
A-ECS
tygyh
force-pushed
the
patch-2
branch
3 times, most recently
from
9cd1ec1
to
f0c38bc
Compare
|
Several unrelated changes had to be made to please the CI. I do not know why. |
I guess new rust version just released or something like that. Can you remove these changes please? They are handled in the separate PR: #11123 |
tygyh
force-pushed
the
patch-2
branch
2 times, most recently
from
47ddc68
to
2117626
Compare
james7132
reviewed
Jan 1, 2024
examples/ecs/ecs_guide.rs
Outdated
| // for this case. A `Local<T>` refers to a value owned by the system of type `T`, which is automatically | ||
| // initialized using `T`'s `FromWorld`* implementation. In this system's `Local` (`counter`), `T` is `u32`. | ||
| // for this case. A `Local<T>` refers to a value of type `T` that is owned by the system. | ||
| // This value is automatically initialized using `T`'s `FromWorld`* implementation. |
There was a problem hiding this comment.
Suggested change
| // This value is automatically initialized using `T`'s `FromWorld`* implementation. | |
| // This value is automatically initialized using `T`'s `FromWorld`* implementation upon the system's initialization. |
This might reformatting afterwards, but it's important to note when it's initialized.
doonv
approved these changes
Jan 1, 2024
mockersf
approved these changes
Feb 1, 2024
mockersf
added
the
S-Ready-For-Final-Review
tjamaan
pushed a commit
to tjamaan/bevy
that referenced
this pull request
Feb 6, 2024
) # Objective - Finish PR bevyengine#10322 ## Solution - Rebase changes in PR bevyengine#10322 and format the changes. Co-authored-by: Mauer-Oats <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution