Don't unconditionally enable bevy_render or bevy_assets if mutli-threaded feature is enabled #11726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -77,7 +77,7 @@ serialize = [ | |||
| multi-threaded = [ | |||
| "bevy_asset/multi-threaded", | |||
| "bevy_ecs/multi-threaded", | |||
| "bevy_render/multi-threaded", | |||
| "bevy_render?/multi-threaded", | |||
There was a problem hiding this comment.
Neat, I hadn't seen this syntax before. Do you have docs to link for this?
There was a problem hiding this comment.
https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html doesn't appear to mention it.
There was a problem hiding this comment.
Aha: https://doc.rust-lang.org/cargo/reference/features.html
The "package-name/feature-name" syntax will also enable package-name if it is an optional dependency. Often this is not what you want. You can add a ? as in "package-name?/feature-name" which will only enable the given feature if something else enables the optional dependency.
alice-i-cecile
approved these changes
Feb 5, 2024
mockersf
reviewed
Feb 5, 2024
alice-i-cecile
added
C-Bug
AxiomaticSemantics
changed the title
james7132
approved these changes
Feb 6, 2024
james7132
added
the
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
bevy_render has been set to be automatically enabled if mutlti-threaded feature is
Solution
make it conditional