Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't unconditionally enable bevy_render or bevy_assets if mutli-threaded feature is enabled #11726

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Don't unconditionally enable bevy_render or bevy_assets if mutli-threaded feature is enabled #11726

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35e0daf
Don't unconditionally enable bevy_render if multi-threaded feature is…
AxiomaticSemantics Feb 5, 2024
06251d2
Make bevy_assets conditionally enable multi-threaded feature
AxiomaticSemantics Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/bevy_internal/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,9 @@ serialize = [
"bevy_ui?/serialize",
]
multi-threaded = [
"bevy_asset/multi-threaded",
"bevy_asset?/multi-threaded",
"bevy_ecs/multi-threaded",
"bevy_render/multi-threaded",
"bevy_render?/multi-threaded",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, I hadn't seen this syntax before. Do you have docs to link for this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html doesn't appear to mention it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha: https://doc.rust-lang.org/cargo/reference/features.html

The "package-name/feature-name" syntax will also enable package-name if it is an optional dependency. Often this is not what you want. You can add a ? as in "package-name?/feature-name" which will only enable the given feature if something else enables the optional dependency.

"bevy_tasks/multi-threaded",
]
async-io = ["bevy_tasks/async-io"]
Expand Down
Loading