Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new parameter skip_munging for rabbitmq_parameter #3

Closed
wants to merge 1 commit into from

Conversation

joec4i
Copy link

@joec4i joec4i commented Nov 25, 2020

Pull Request (PR) description

Add new parameter skip_munging for rabbitmq_parameter to prevent numberic strings from being converted to integers.

This Pull Request (PR) fixes the following issues

We have several x-content-hash exchanges which use a numeric string as the routing key. As a result, shovels for these exchanges would include key value pairs like this "src-exchange-key": "5". By default the string "5" will be converted to an integer. However, RabbitMQ doesn't accept exchange keys to be integers. As a result, we'd run into errors from RabbitMQ

Error:
Validation failed
dest-exchange-key should be binary, actually was 5
src-exchange-key should be binary, actually was 5

This PR would allow the auto type conversion to be disabled and therefore numeric strings to be included in the RabbitMQ parameter payload if needed.

@joec4i
Copy link
Author

joec4i commented Nov 25, 2020

Closing this in favour of voxpupuli#865

@joec4i joec4i closed this Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant