Add new parameter autoconvert for rabbitmq_parameter

[joec4i]

Pull Request (PR) description

Add a new parameter autoconvert for rabbitmq_parameter to allow users to disable auto type conversion from numeric strings to integers if needed.

This Pull Request (PR) fixes the following issues

We have several x-content-hash exchanges which use a numeric string as the routing key. Due to the munge_value implementation, the routing key would be converted to an integer.

As a result, a valid payload to create a shovel as below

{
  "component": "shovel",
  "vhost": "foo",
  "name": "test",
  "value": {
    "src-uri": "amqps://user:[redacted]@rabbit.service.consul:5671/foo",
    "src-exchange-key": "5",
    "dest-uri": "amqps://user:[redacted]@rabbit.service.consul:5671/bar",
    "dest-exchange-key": "5",
    "ack-mode": "on-confirm",
    "src-protocol": "amqp091",
    "dest-protocol": "amqp091",
    "src-exchange": "indexer_document_requests",
    "src-delete-after": "never",
    "dest-exchange": "indexer_document_requests",
    "dest-add-forward-headers": false
  }
}

will be converted to

{
  "component": "shovel",
  "vhost": "foo",
  "name": "test",
  "value": {
    "src-uri": "amqps://user:[redacted]@rabbit.service.consul:5671/foo",
    "src-exchange-key": 5,
    "dest-uri": "amqps://user:[redacted]@rabbit.service.consul:5671/bar",
    "dest-exchange-key": 5,
    "ack-mode": "on-confirm",
    "src-protocol": "amqp091",
    "dest-protocol": "amqp091",
    "src-exchange": "indexer_document_requests",
    "src-delete-after": "never",
    "dest-exchange": "indexer_document_requests",
    "dest-add-forward-headers": false
  }
}

Because RabbitMQ doesn't accept exchange keys to be integers, it'll throw out validation errors:

Error:
Validation failed
dest-exchange-key should be binary, actually was 5
src-exchange-key should be binary, actually was 5

This PR would allow the auto type conversion to be disabled and therefore numeric strings to be included in the RabbitMQ parameter payload if needed. The users would be responsible to ensure the right date types are used if autoconvert is set to false.

[wyardley]

Looks reasonable to me, provided it’s used carefully. Would it be good to make the parameter refer to autoconvert vs munge?

[joec4i]

Looks reasonable to me, provided it’s used carefully. Would it be good to make the parameter refer to autoconvert vs munge?

Good point @wyardley . I've renamed the parameter to autoconvert which defaults to true. Please have another look. Thanks!

[wyardley]

LGTM. Would you mind squashing down to one commit in your branch?

[joec4i]

Thanks, Will! It's in one commit now.

[wyardley]

Cool. Going to leave this open for a day or two in case anyone else wants to review / comment. I’ll try to cut a new release after merging this.

[nmaludy]

LGTM