Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backward compatible to v2.2 #337

Closed
kta opened this issue Apr 23, 2018 · 1 comment
Closed

backward compatible to v2.2 #337

kta opened this issue Apr 23, 2018 · 1 comment

Comments

@kta
Copy link
Contributor

kta commented Apr 23, 2018

Version 2.3 is not backward compatible with features such as parser

Therefore, an error occurs in a framework other than Rails.

https:/bkeepers/dotenv/blob/master/lib/dotenv/parser.rb#L33

Correction example

      def call(string, is_load = false)         # add default value
        new(string, is_load).call
      end
    end

    def initialize(string, is_load = false)     # add default value
      @string = string
      @hash = {}
      @is_load = is_load
    end

dotenv version:
2.3.0

Ruby version:
2.4.2

@jonmagic
Copy link
Collaborator

Closed by #338

Maintainers note: Looks like folks use the private API's so we'll have to think about if we want to remain backwards compatible for internal changes or just declare these API's as public?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants