backward compatible to v2.2 as parser #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spica831 thank you for the contribution ✨ |
jessedoyle
added a commit
to jessedoyle/dotenv
that referenced
this pull request
May 1, 2018
* Commit 7f82f73 introduced a backwards-incompatible change with the current API with respect to `Dotenv::Environment#intialize` by changing the method signature. * Make the new parameter default to false to retain backwards compatibility. * Similar changes were made for `Dotenv::Parser` in bkeepers#338. SEE: bkeepers#323 SEE: bkeepers#338
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#338
Version 2.3 is not backward compatible with features such as
parserTherefore, since we made backwards compatibility for
parser, I would like to confirm it