Backwards Compatible Dotenv::Environment #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Commit 7f82f73 introduced a backwards-incompatible change with the current API with respect to `Dotenv::Environment#intialize` by changing the method signature. * Make the new parameter default to false to retain backwards compatibility. * Similar changes were made for `Dotenv::Parser` in bkeepers#338. SEE: bkeepers#323 SEE: bkeepers#338
KrauseFx
approved these changes
May 3, 2018
There was a problem hiding this comment.
This is a really important PR that should be merged and shipped 🚀 Thanks @jessedoyle 👍
|
@cadwallion have you given any thought to this release? I know it's broken many frameworks. Is there a specific need to cause the breaking change? |
|
Thank you for this, I'll get this into the release I'm cutting shortly. |
|
This was included in version 2.5.0, released a few minutes ago. |
|
Awesome... thanks @cadwallion |
This was referenced Jun 21, 2018
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dotenv::Environment#intializeby changing the method signature.Dotenv::Parserin backward compatible to v2.2 as parser #338.SEE: #323
SEE: #338