-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restyle named/unnamed "tab group" title tags #20920
Comments
I am also seeing this issue on my end. The tab outline looks great now due to #24095 being fixed, but the group labels definitely need to be fixed as well. It's like the last thing that will make tab groups finally look polished in Brave. For example, look at the label The purple box surrounding the label barely has any padding against the tab outline, making it look like its merging with it. Rounding out the corners of the label box will also make it more appealing and more in line with the unnamed group circles. |
The title tags that float left of a tab group seem to be unpolished and in disagreement with Brave's theme. It seems there was an attempt to style these differently than what was ported from Chromium, so I hope this can still be revisited all the same.
(Not to be mistaken for issue #14765, which is chiefly concerned with tab group spacing/overlapping)
Description
Steps to Reproduce
Actual result:
Named group tags lack rounded corners and padding almost completely, contrasting starkly against the entirely round tags of the unnamed.
(I suspect the slight clipping on the left of the unnamed is due to my display scaling)
Expected result:
Something like this (Chrome 97):
... but a touch less rounded, more compact, and befitting of our Brave!
Reproduces how often:
Easily reproduced
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
None
The text was updated successfully, but these errors were encountered: