Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab group outline is not rendered properly with light theme #24095

Closed
simonhong opened this issue Jul 18, 2022 · 2 comments · Fixed by brave/brave-core#14210
Closed

Tab group outline is not rendered properly with light theme #24095

simonhong opened this issue Jul 18, 2022 · 2 comments · Fixed by brave/brave-core#14210

Comments

@simonhong
Copy link
Member

simonhong commented Jul 18, 2022

Description

Inactive tab also should have thicker bottom line when it's included in any tab group

Steps to Reproduce

  1. Launch Brave
  2. Create tab group via tab's context menu (Add Tab to Group)
  3. Check inactive tab's bottom bottom line in the tab group

Actual result:

image

image

Expected result:

Works properly with dark theme like below.
image
image

Reproduces how often:

100%

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@MadhaviSeelam
Copy link

MadhaviSeelam commented Aug 2, 2022

Verification PASSED using

Brave | 1.43.54 Chromium: 104.0.5112.69 (Official Build) beta (64-bit)
-- | --
Revision | 7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213}
OS | Windows 11 Version 21H2 (Build 22000.795)

Reproducibility:

Reproduced in 1.41.100 using STR from #24095 (comment)
image

Confirmed tab group border thickness in light theme rendered as expected and compared with dark mode for Normal window

dark light
image image

Verification:

Confirmed tab group border thickness rendered as expected for Guest window, Private window and TOR window

GW PW TOR
image image image

@urbenlegend
Copy link

The tab outline looks great now, but can we also fix the padding and corner radius of the group labels? It's like the last thing that will make tab groups finally look polished in Brave.

For example, look at the label Test below:
image
The purple box surrounding the label barely has any padding against the tab outline, making it look like its merging with it. Rounding out the corners of the box will also make it more appealing and more in line with the unnamed group circles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants