Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to import saved passwords from Edge (Chromium, macOS, Linux) #24343

Closed
stephendonner opened this issue Jul 29, 2022 · 6 comments · Fixed by brave/brave-core#14559
Closed

Comments

@stephendonner
Copy link

stephendonner commented Jul 29, 2022

Description

Unable to import saved passwords from Edge (Chromium, macOS)

Steps to Reproduce

  1. seed a Microsoft Edge profile with saved password(s)
  2. double-check that edge://settings/passwords has entries
  3. install 1.44.8
  4. launch Brave
  5. click on Skip welcome screen
  6. click on Import bookmarks now...
  7. choose Microsoft Edge Profile 1
  8. note that Saved passwords is listed and checked, by default
  9. click on Import

Actual result:

No saved passwords are imported

Screenshot 2022-07-29 at 1 45 29 PM

Expected result:

Should import saved passwords; they should show up in brave://settings/passwords

Screenshot 2022-07-29 at 1 48 00 PM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.44.8 Chromium: 104.0.5112.69 (Official Build) nightly (x86_64)
Revision 7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213}
OS macOS Version 13.0 (Build 22A5311f)

cc @rebron @spylogsster @simonhong @LaurenWags

@stephendonner stephendonner changed the title Unable to import saved passwords from Edge (macOS) Unable to import saved passwords from Edge (Chromium, macOS) Jul 30, 2022
@LaurenWags LaurenWags changed the title Unable to import saved passwords from Edge (Chromium, macOS) Unable to import saved passwords from Edge (Chromium, macOS, Linux) Aug 1, 2022
@LaurenWags
Copy link
Member

Reproduces with Linux as well (Ubuntu 20.04)

Brave	1.42.84 Chromium: 104.0.5112.69 (Official Build) (64-bit) 
Revision	7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213}
OS	Linux

@bsclifton
Copy link
Member

Related #24130

@kjozwiak
Copy link
Member

The above will require 1.43.77 or higher for 1.43.x verification 👍

@kjozwiak
Copy link
Member

The above will require 1.43.80 or higher for 1.43.x verification. Looks like we missed the Edge portion of the fix from brave/brave-core#14559 when uplifting brave/brave-core#14663. @spylogsster created brave/brave-core#14741 which adds the Edge cases 👍

@stephendonner
Copy link
Author

Verification PASSED using

Brave 1.43.80 Chromium: 104.0.5112.102 (Official Build) dev (x86_64)
Revision 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS macOS Version 11.6.8 (Build 20G730)

Followed my original steps to reproduce.

Confirmed I was able to import and use Edge passwords.

example example example example example example
Screen Shot 2022-08-23 at 8 14 29 AM Screen Shot 2022-08-23 at 8 14 32 AM Screen Shot 2022-08-23 at 8 14 42 AM Screen Shot 2022-08-23 at 8 15 43 AM Screen Shot 2022-08-23 at 8 15 57 AM Screen Shot 2022-08-23 at 8 16 02 AM

@btlechowski
Copy link

btlechowski commented Aug 26, 2022

Verification passed on

Brave 1.43.81 Chromium: 104.0.5112.102 (Official Build) (64-bit)
Revision 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS Ubuntu 18.04 LTS

Issue is still reproducible. Per our process created a follow up #25001

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment